On Sun, Nov 1, 2020 at 10:15 AM Thomas Monjalon <tho...@monjalon.net> wrote: > > The new txgbe driver in the next-net is also using ‘udata64’, that also > > needs to > > be updated. cc'ed txgbe maintainer. > > That's a pity it did not take into account the deprecation notice. > What kind of hack is it used for? > Can it be simply removed to allow quick merging of the PMD?
+1 for removing. It seems to be a provision for future features, as this field is simply passed to an internal function that does not use it. $ git grep -C 2 udata drivers/net/txgbe/ drivers/net/txgbe/txgbe_rxtx.c- drivers/net/txgbe/txgbe_rxtx.c- txgbe_set_xmit_ctx(txq, ctx_txd, tx_ol_req, drivers/net/txgbe/txgbe_rxtx.c: tx_offload, &tx_pkt->udata64); drivers/net/txgbe/txgbe_rxtx.c- drivers/net/txgbe/txgbe_rxtx.c- txe->last_id = tx_last; $ git grep -C 2 txgbe_set_xmit_ctx drivers/net/txgbe/ drivers/net/txgbe/txgbe_rxtx.c- drivers/net/txgbe/txgbe_rxtx.c-static inline void drivers/net/txgbe/txgbe_rxtx.c:txgbe_set_xmit_ctx(struct txgbe_tx_queue *txq, drivers/net/txgbe/txgbe_rxtx.c- volatile struct txgbe_tx_ctx_desc *ctx_txd, drivers/net/txgbe/txgbe_rxtx.c- uint64_t ol_flags, union txgbe_tx_offload tx_offload, -- drivers/net/txgbe/txgbe_rxtx.c- } drivers/net/txgbe/txgbe_rxtx.c- drivers/net/txgbe/txgbe_rxtx.c: txgbe_set_xmit_ctx(txq, ctx_txd, tx_ol_req, drivers/net/txgbe/txgbe_rxtx.c- tx_offload, &tx_pkt->udata64); drivers/net/txgbe/txgbe_rxtx.c- $ git grep -w mdata drivers/net/txgbe/ drivers/net/txgbe/txgbe_rxtx.c: __rte_unused uint64_t *mdata) -- David Marchand
