29/10/2020 11:20, Andrew Rybchenko: > On 10/29/20 12:27 PM, Thomas Monjalon wrote: > > The mbuf timestamp is moved to a dynamic field > > in order to allow removal of the deprecated static field. > > The related mbuf flag is also replaced. > > > > Signed-off-by: Thomas Monjalon <tho...@monjalon.net> > > --- > > --- a/app/test-pmd/util.c > > +++ b/app/test-pmd/util.c > > +static inline bool > > +is_timestamp_enabled(const struct rte_mbuf *mbuf) > > +{ > > + static uint64_t timestamp_rx_dynflag; > > + > > + int timestamp_rx_dynflag_offset; > > + > > + if (timestamp_rx_dynflag == 0) { > > + timestamp_rx_dynflag_offset = rte_mbuf_dynflag_lookup( > > + RTE_MBUF_DYNFLAG_RX_TIMESTAMP_NAME, NULL); > > If the flag is not registered, it will try to lookup on every > call. I'm not sure that it is good.
I don't see the problem. It is a dump in a test application. The idea is to have a fresh dump whatever was updated recently.