On Thu, 2020-10-08 at 10:40 +0100, Hariprasad Govindharajan wrote: > With DPDK 20.11 release, the igb_uio module is no more part of DPDK. > There are use cases where this module is required, for example while > testing the virtual ports in OvS, the virtual ports are bound to > igb_uio module inside a VM. So, this patch provides a Makefile > which can be used to build this module and use as needed. > > Before building this module, the user is expected to build the > DPDK using meson build system and make sure that the required > libraries are installed in the path /usr/local > > Signed-off-by: Hariprasad Govindharajan <hariprasad.govindhara...@intel.com> > --- > This patch will be part of dpdk-kmods repo > https://git.dpdk.org/dpdk-kmods/ > --- > v4: > Corrected the indentation > v3: > Edited the commit message and corrected the mistakes in the variable > definition > v2: > Added more information to the commit message > --- > linux/igb_uio/Makefile | 8 ++++++++ > 1 file changed, 8 insertions(+) > create mode 100644 linux/igb_uio/Makefile > > diff --git a/linux/igb_uio/Makefile b/linux/igb_uio/Makefile > new file mode 100644 > index 0000000..45dbe42 > --- /dev/null > +++ b/linux/igb_uio/Makefile > @@ -0,0 +1,8 @@ > +DPDK_HEADERS ?= /usr/local/include
Please don't hard-code values that are provided programmatically. Use pkgconfing instead: $(shell pkg-config --variable=includedir libdpdk) > +RTE_KERNELDIR ?= /lib/modules/`uname -r`/build This is not a dpdk specific location so it doesn't need an RTE prefix. While there isn't a unique way of calling this, the most common name I see being used is KSRC. > + > +all: > + make EXTRA_CFLAGS="-I $(DPDK_HEADERS)" -C $(RTE_KERNELDIR)/ M=$(PWD) > + > +clean: > + make -C $(RTE_KERNELDIR)/ M=$(PWD) clean -- Kind regards, Luca Boccassi
