On 26-Oct-20 6:44 PM, Pallavi Kadam wrote:
Currently, since there is no runtime directory set, the code tries to create a file in C:\ which is only writable with administrator privileges. As a result, if the user is not admin, the application will fail. So, forcing no_shconf to 1 to prevent the code having to create files in the runtime directory.Suggested-by: Dmitry Kozlyuk <dmitry.kozl...@gmail.com> Signed-off-by: Pallavi Kadam <pallavi.ka...@intel.com> Reviewed-by: Ranjit Menon <ranjit.me...@intel.com> --- lib/librte_eal/windows/eal.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c index 6334aca03..105549de1 100644 --- a/lib/librte_eal/windows/eal.c +++ b/lib/librte_eal/windows/eal.c @@ -295,6 +295,7 @@ rte_eal_init(int argc, char **argv) RTE_LOG(WARNING, EAL, "Multi-process support is requested, " "but not available.\n"); internal_conf->in_memory = 1; + internal_conf->no_shconf = 1; }if (!internal_conf->no_hugetlbfs && (eal_hugepage_info_init() < 0)) {
This is the correct way, as in-memory implies no_shconf. I would like to deprecate noshconf option as it's a subset of what in-memory does.
Acked-by: Anatoly Burakov <anatoly.bura...@intel.com> -- Thanks, Anatoly
