Re: [dpdk-dev] [PATCH v4 0/6] net/mlx5: add Rx buffer split support

[Ferruh Yigit]

On 10/26/2020 5:38 PM, Slava Ovsiienko wrote:
Hi,  Ferruh
PSB
-----Original Message-----
From: Ferruh Yigit <ferruh.yi...@intel.com>
Sent: Monday, October 26, 2020 19:04
To: Raslan Darawsheh <rasl...@nvidia.com>; Slava Ovsiienko
<viachesl...@nvidia.com>; dev@dpdk.org
Cc: NBU-Contact-Thomas Monjalon <tho...@monjalon.net>; Matan Azrad
<ma...@nvidia.com>; Alexander Kozyrev <akozy...@nvidia.com>; Ori Kam
<or...@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH v4 0/6] net/mlx5: add Rx buffer split support

On 10/26/2020 3:25 PM, Raslan Darawsheh wrote:
Hi,

-----Original Message-----
From: Viacheslav Ovsiienko <viachesl...@nvidia.com>
Sent: Monday, October 26, 2020 1:55 PM
To: dev@dpdk.org
Cc: NBU-Contact-Thomas Monjalon <tho...@monjalon.net>; Matan Azrad
<ma...@nvidia.com>; Alexander Kozyrev <akozy...@nvidia.com>; Raslan
Darawsheh <rasl...@nvidia.com>; Ori Kam <or...@nvidia.com>
Subject: [PATCH v4 0/6] net/mlx5: add Rx buffer split support

This patch adds to PMD the functionality for the receiving buffer
split feasture [1]

[1]
https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatc
h
es.dpdk.org%2Fpatch%2F81154%2F&amp;data=02%7C01%7Crasland%40nvid

ia.com%7Ccf4913c6b58346b50b1b08d879a60608%7C43083d15727340c1b7db
3

9efd9ccc17a%7C0%7C0%7C637393101256743078&amp;sdata=fyiL3PS8r8wv8u
pyOYUtITkVqId9DZsF9LvSJQL9fdM%3D&amp;reserved=0

Signed-off-by: Viacheslav Ovsiienko <viachesl...@nvidia.com>

---
v1:
https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatc
h
es.dpdk.org%2Fpatch%2F81808%2F&amp;data=02%7C01%7Crasland%40nvid

ia.com%7Ccf4913c6b58346b50b1b08d879a60608%7C43083d15727340c1b7db
3

9efd9ccc17a%7C0%7C0%7C637393101256743078&amp;sdata=NPBFlGmVN6bi
GUpzHC%2FrOVmdMoK2fkYRC0%2FDB%2BNlNno%3D&amp;reserved=0

v2:
https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatc
h
es.dpdk.org%2Fpatch%2F81923%2F&amp;data=02%7C01%7Crasland%40nvid

ia.com%7Ccf4913c6b58346b50b1b08d879a60608%7C43083d15727340c1b7db
3

9efd9ccc17a%7C0%7C0%7C637393101256743078&amp;sdata=YwYjMz3jrSYU6
RBgwl0DmQfmjwwymNJTFjMdx0rsm2U%3D&amp;reserved=0
      - typos
      - documentation is updated

v3:
https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatc
h
es.dpdk.org%2Fpatch%2F82177%2F&amp;data=02%7C01%7Crasland%40nvid

ia.com%7Ccf4913c6b58346b50b1b08d879a60608%7C43083d15727340c1b7db
3

9efd9ccc17a%7C0%7C0%7C637393101256743078&amp;sdata=HVvLbWS0sJxu
v%2Bc%2BKIMqllBq3edC4v0GD%2BtrwS7%2FsRo%3D&amp;reserved=0
      - extra parameter checks in PMD rx_queue_setup removed
      - minor optimizations in PMD

v4: - rebasing

Viacheslav Ovsiienko (6):
    net/mlx5: add extended Rx queue setup routine
    net/mlx5: configure Rx queue to support split
    net/mlx5: register multiple pool for Rx queue
    net/mlx5: update Rx datapath to support split
    net/mlx5: report Rx segmentation capabilities
    doc: add buffer split feature limitation to mlx5 guide

   doc/guides/nics/mlx5.rst        |   6 +-
   drivers/net/mlx5/mlx5.h         |   3 +
   drivers/net/mlx5/mlx5_ethdev.c  |   4 ++
   drivers/net/mlx5/mlx5_mr.c      |   3 +
   drivers/net/mlx5/mlx5_rxq.c     | 136
+++++++++++++++++++++++++++++++++++-----
   drivers/net/mlx5/mlx5_rxtx.c    |   3 +-
   drivers/net/mlx5/mlx5_rxtx.h    |  13 +++-
   drivers/net/mlx5/mlx5_trigger.c |  20 +++---
   8 files changed, 160 insertions(+), 28 deletions(-)

--
1.8.3.1

Series applied to next-net-mlx,


The feature was references with different name in each commit, I tried to unify
it as "Rx buffer split" in next-net.
Can you please double check the updated commit log/titles?

        doc: add Rx buffer split limitation to mlx5 guide
        net/mlx5: report Rx buffer split capabilities
OK about above.

        net/mlx5: support Rx buffer split
It would be better: "net/mlx5: support Rx buffer split on datapath


Isn't the supporting the "Rx buffer split" mean supporting it on the datapath, 
where else it can be supported, the "on datapath" looks redundant to me.

        net/mlx5: register multiple pool for Rx queue
OK

        net/mlx5: configure Rx buffer split
It would be better: "net/mlx5: configure Rx queue for buffer split"


Like above, isn't the configure "Rx buffer split" mean configuring Rx queue for 
it, "Rx queue" looks redundant to me.

For both above, if you have strong opinion to update them, I can. But I prefer 
shorter versions.

        net/mlx5: receive Rx buffer split description
IMO, it would be better: "net/mlx5: handle Rx buffer split description"
or
"net/mlx5: support Rx buffer split description"


OK to use "net/mlx5: support Rx buffer split description"

Could you, please, also squash the hotfix:
http://patches.dpdk.org/patch/82218/


OK