26/10/2020 15:34, Andrew Rybchenko:
> On 10/26/20 5:29 PM, Thomas Monjalon wrote:
> > 26/10/2020 11:40, David Marchand:
> >> On Mon, Oct 26, 2020 at 6:21 AM Thomas Monjalon <tho...@monjalon.net>
> >> wrote:
> >>> + node_mbuf_priv1_dynfield_offset =
> >>> rte_mbuf_dynfield_register(
> >>> + &node_mbuf_priv1_dynfield_desc);
> >>> + if (node_mbuf_priv1_dynfield_offset < 0)
> >>> + return -1;
> >>
> >> How about return -rte_errno like what is done in setup_lpm()?
> >
> > Yes, looks better
> >
> > [...]
> >>> +static const struct rte_mbuf_dynfield node_mbuf_priv1_dynfield_desc = {
> >>> + .name = "rte_node_dynfield_priv1",
> >>> + .size = sizeof(uint64_t),
> >>> + .align = __alignof__(uint64_t),
> >>
> >> s/uint64_t/struct node_mbuf_priv1/g ?
> >
> > Yes will do
> >
>
> Just to be sure - "struct node_mbuf_priv1 *"
Yes, pointer to node_mbuf_priv1.
