> -----Original Message----- > From: dev <dev-boun...@dpdk.org> On Behalf Of Tom Rix > Sent: Wednesday, October 21, 2020 2:58 PM > To: Chautru, Nicolas <nicolas.chau...@intel.com>; dev@dpdk.org; > akhil.go...@nxp.com > Cc: Richardson, Bruce <bruce.richard...@intel.com> > Subject: Re: [dpdk-dev] [PATCH] baseband/acc100: remove logically dead > code > > > On 10/19/20 2:09 PM, Nicolas Chautru wrote: > > Coverity reported dead code for a few error checks which are indeed > > not reachable. > > > > Coverity issue: 363451, 363454, 363455 > > > > Signed-off-by: Nicolas Chautru <nicolas.chau...@intel.com> > > This change looks fine. > > Should remove the 'Coverity issue: ... ' from the log. > > Reviewed-by: Tom Rix <t...@redhat.com>
It should stay. That is the convention we use: git log | grep "Coverity issue"