On Thu, Oct 22, 2020 at 11:45 AM Lance Richardson
<lance.richard...@broadcom.com> wrote:
>
> Use boolean AND operator instead of bitwise operator.
>
> Coverity issue: 323488
> Fixes: b42c15c83e88 ("net/bnxt: support trusted VF")
> Signed-off-by: Lance Richardson <lance.richard...@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khapa...@broadcom.com>
Patch applied to dpdk-next-net-brcm.
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index aa2d9e00e..3ee4b5524 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -1547,7 +1547,7 @@ static int bnxt_mac_addr_add_op(struct rte_eth_dev
> *eth_dev,
> if (rc)
> return rc;
>
> - if (BNXT_VF(bp) & !BNXT_VF_IS_TRUSTED(bp)) {
> + if (BNXT_VF(bp) && !BNXT_VF_IS_TRUSTED(bp)) {
> PMD_DRV_LOG(ERR, "Cannot add MAC address to a VF
> interface\n");
> return -ENOTSUP;
> }
> --
> 2.25.1
>
