On Wed, Jul 08, 2015 at 12:27:34PM +0100, Pablo de Lara wrote: > rte_hash structure should not be a public structure, > and therefore it should be moved to the C file and be declared > as internal. rte_hash_hash implementation is also moved > to the C file, as it uses the structure. > > This patch also removes part of a unit test that was checking > a field of the structure. > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>
Irrespective of whether or not we change the underlying hash table implementation this looks a good change to me. The rte_hash structure should not be used directly by any applications - the APIs all take pointers to the structure, so there should be no ABI breakage from this, I think. Therefore: Acked-by: Bruce Richardson <bruce.richardson at intel.com>
