On Wed, Jul 08, 2015 at 11:52:51AM +0200, Thomas Monjalon wrote: > Hi Neil, > > 2015-06-29 09:59, Neil Horman: > > - * int __vsym foo_v20(char *string) > > + * int foo_v20(char *string) > [...] > > -#define BIND_DEFAULT_SYMBOL(b, e, n) __asm__(".symver " RTE_STR(b) > > RTE_STR(e) ", "RTE_STR(b)"@@DPDK_"RTE_STR(n)) > > +#define BIND_DEFAULT_SYMBOL(b, e, n) __asm__(".symver " RTE_STR(b) > > RTE_STR(e) ", " RTE_STR(b) "@@DPDK_" RTE_STR(n)) > > #define __vsym __attribute__((used)) > > In this patch, you removed __vsym from the example but the #define still > exists. > Should it be removed? or documented? > > Thanks >
The latter, I'll try send a follow on patch today Neil