On 2015/07/07 17:06, David Marchand wrote:
> On Mon, Jul 6, 2015 at 8:24 AM, Tetsuya Mukawa <mukawa at igel.co.jp
> <mailto:mukawa at igel.co.jp>> wrote:
>
> From: "Tetsuya.Mukawa" <mukawa at igel.co.jp <mailto:mukawa at
> igel.co.jp>>
>
> The patch consolidates below functions, and implemented in common
> eal code.
> - pci_map_device()
> - pci_unmap_device()
>
> Signed-off-by: Tetsuya Mukawa <mukawa at igel.co.jp
> <mailto:mukawa at igel.co.jp>>
> ---
> lib/librte_eal/bsdapp/eal/eal_pci.c | 3 ++
> lib/librte_eal/common/eal_common_pci.c | 57
> +++++++++++++++++++++++++++++++++
> lib/librte_eal/common/eal_private.h | 19 +++++++++++
> lib/librte_eal/common/include/rte_pci.h | 1 +
> lib/librte_eal/linuxapp/eal/eal_pci.c | 53
> ------------------------------
> lib/librte_ether/rte_ethdev.c | 2 ++
> 6 files changed, 82 insertions(+), 53 deletions(-)
>
> diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c
> b/lib/librte_eal/bsdapp/eal/eal_pci.c
> index f85fc1e..a27dca3 100644
> --- a/lib/librte_eal/bsdapp/eal/eal_pci.c
> +++ b/lib/librte_eal/bsdapp/eal/eal_pci.c
> @@ -240,6 +240,9 @@ pci_scan_one(int dev_pci_fd, struct pci_conf
> *conf)
> /* FreeBSD has no NUMA support (yet) */
> dev->numa_node = 0;
>
> + /* FreeBSD has only one pass through driver */
> + dev->kdrv = RTE_KDRV_NIC_UIO;
> +
>
>
> Do we need a new define for this ?
>
> I know this is not really part of this patchset, but this kdrv should
> just disappear.
Could I make sure this?
It seems 'struct rte_pci_device' still has kdrv member, also my patch
defines RTE_KDRV_NIC_UIO like below.
--- a/lib/librte_eal/common/include/rte_pci.h
+++ b/lib/librte_eal/common/include/rte_pci.h
@@ -149,6 +149,7 @@ enum rte_kernel_driver {
RTE_KDRV_IGB_UIO,
RTE_KDRV_VFIO,
RTE_KDRV_UIO_GENERIC,
+ RTE_KDRV_NIC_UIO,
};
Do you mean kdrv member will disappear in next DPDK release?
Tetsuya
>
>
> --
> David Marchand
