On 10/16/2020 5:05 PM, Thomas Monjalon wrote:
16/10/2020 17:47, Ferruh Yigit:
On 10/16/2020 2:39 PM, Viacheslav Ovsiienko wrote:
+__rte_experimental
+struct rte_eth_rxseg_split {
+ struct rte_mempool *mp; /**< Memory pool to allocate segment from. */
+ uint16_t length; /**< Segment data length, configures split point. */
+ uint16_t offset; /**< Data offset from beginning of mbuf data buffer. */
+ uint32_t reserved; /**< Reserved field. */
+};
+
+/**
+ * A common structure used to describe Rx packet segment properties.
+ */
+__rte_experimental
+union rte_eth_rxseg {
+ /* The settings for buffer split offload. */
+ struct rte_eth_rxseg_split split;
+ /* The other features settings should be added here. */
+};
Is the '__rte_experimental' on the data structs do anything other than
documentation?
icc is complaining about them [1], if they are only for documenation, would it
be OK to move it to the comment and remove the '__rte_experimental' tag?
[1]
../lib/librte_ethdev/rte_ethdev.h(1005): error #2651: attribute does not apply
to any entity
__rte_experimental
^
Yes should be a comment.
Following is a sample from rte_flow.h as comment:
https://git.dpdk.org/dpdk/tree/lib/librte_ethdev/rte_flow.h?h=v20.08#n1392
