On 10/16/2020 10:52 AM, Jiawen Wu wrote:
On 10/15/2020 8:56 AM Ferruh Yigit wrote:
On 10/14/2020 6:54 AM, Jiawen Wu wrote:
Add basic PCIe ethdev probe and remove.
Signed-off-by: Jiawen Wu <jiawe...@trustnetic.com>
<...>
+RTE_LOG_REGISTER(txgbe_logtype_init, pmd.net.txgbe.init, NOTICE);
+RTE_LOG_REGISTER(txgbe_logtype_driver, pmd.net.txgbe.driver, NOTICE);
+
+#ifdef RTE_LIBRTE_TXGBE_DEBUG_RX
+ RTE_LOG_REGISTER(txgbe_logtype_rx, pmd.net.txgbe.rx, DEBUG); #endif
+#ifdef RTE_LIBRTE_TXGBE_DEBUG_TX
+ RTE_LOG_REGISTER(txgbe_logtype_tx, pmd.net.txgbe.tx, DEBUG); #endif
+
+#ifdef RTE_LIBRTE_TXGBE_DEBUG_TX_FREE
+ RTE_LOG_REGISTER(txgbe_logtype_tx_free, pmd.net.txgbe.tx_free,
+DEBUG); #endif
Can you please document available logging types in the driver documentation?
("pmd.net.txgbe.init", .. etc)
Since there is no config/common_base, which file should I add the default values
of these config parameters? (RTE_LIBRTE_TXGBE_DEBUG_RX .. etc)
There is no way to provide default values now [1], or no place to list the
existing config options.
In meson these compile time flags can be provided as arguments to build, like
meson -Dc_args="-DRTE_LIBRTE_TXGBE_DEBUG_RX" build
That is why,
1- We are trying to reduce compile time flags as much as possible.
2- For the compile time flags we can't remove, they need to be listed/documented
in the driver documentation (doc/guides/nics/txgbe.rst for your case), so that
users can be aware of them and can use them.
Please check following sfc patch sent recently, it may help as sample:
https://patches.dpdk.org/patch/80514/
Please document all build options that driver use.
Thanks,
ferruh
[1]
Indeed there is a way, it is 'config/rte_config.h', but that is only for the
cases we have to add the compile time, many driver config doesn't qualify this,
I believe including above discussed ones.
