+static inline void rte_power_monitor(const volatile void *p,
+const uint64_t expected_value, const uint64_t value_mask,
+const uint64_t tsc_timestamp, const uint8_t data_sz)
+{
+RTE_SET_USED(p);
+RTE_SET_USED(expected_value);
+RTE_SET_USED(value_mask);
+RTE_SET_USED(tsc_timestamp);
+RTE_SET_USED(data_sz);
+}

You can probably put NOP implementations of these rte_powe_* functions
into generic/rte_power_intrinsics.h.
So, wouldn't need to duplicate them for every non-supported arch.
Same as it was done for rte_wait_until_equal_*().


Will look into it.

To be completely honest, i don't like that approach. The ifdefery in generic headers looks ugly and out of place, i'd rather leave everything in arch specific header files and provide stubs there.

--
Thanks,
Anatoly

Reply via email to