On Wed, 2020-10-14 at 15:13 +0100, Bruce Richardson wrote:
> The defines used to indicate what crypto, compression and eventdev drivers
> were being built were different to those used in the make build, with meson
> defining them with "_PMD" at the end, while make defined them with "_PMD"
> in the middle and the specific driver name at the end. This might cause
> compatibility issues for applications which used the older defines, which
> switching to build against new DPDK releases.
>
> As well as changing the default to match that of make, meson also
> special-cases the crypto/compression/event drivers to have both defines
> provided. This ensures compatibility for these macros with both meson and
> make from older versions.
>
> For a selection of other libraries and drivers, there were other
> incompatibilities between the meson and make-defined macros which were not
> previously highlighted in a deprecation notice, so we add per-macro
> compatibility defines for these to ease the transition from make to meson.
>
> Fixes: 5b9656b157d3 ("lib: build with meson")
> Fixes: 9314afb68a53 ("drivers: add infrastructure for meson build")
> Fixes: dcadbbde8e61 ("crypto/null: build with meson")
> Fixes: 3c32e89f68e1 ("compress/isal: add skeleton ISA-L compression PMD")
> Fixes: eca504f318db ("drivers/event: build skeleton and SW drivers with
> meson")
>
> Cc: sta...@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richard...@intel.com>
> ---
> app/test/meson.build | 1 +
> config/meson.build | 3 +-
> config/rte_compatibility_defines.h | 129 +++++++++++++++++++++++++++++
> config/rte_config.h | 1 +
> drivers/compress/meson.build | 2 +-
> drivers/crypto/meson.build | 2 +-
> drivers/event/meson.build | 2 +-
> drivers/meson.build | 15 ++++
> 8 files changed, 151 insertions(+), 4 deletions(-)
> create mode 100644 config/rte_compatibility_defines.h
>
> diff --git a/app/test/meson.build b/app/test/meson.build
> index dedf29dd7..fc90a1909 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
> @@ -415,6 +415,7 @@ endif
>
> if dpdk_conf.has('RTE_LIBRTE_PMD_CRYPTO_SCHEDULER')
> driver_test_names += 'cryptodev_scheduler_autotest'
> + test_deps += 'pmd_crypto_scheduler'
> endif
>
> foreach d:test_deps
This change looks out of place in this patch? Was it supposed to be
part of one of the previous commits maybe?
Other than that,
Acked-by: Luca Boccassi <bl...@debian.org>
--
Kind regards,
Luca Boccassi
