14/10/2020 20:53, Dekel Peled: > @@ -292,6 +292,13 @@ API Changes > > * vhost: Moved vDPA APIs from experimental to stable. > > +* ethdev: Added new field ``has_vlan`` to structure ``rte_flow_item_eth``, > + indicating that packet header contains at least one VLAN. > + > +* ethdev: Added new field ``has_more_vlan`` to structure > + ``rte_flow_item_vlan``, indicating that packet header contains at least one > + more VLAN, after this VLAN. > +
The ethdev changes should be grouped with others above vhost one. [...] > - * If the @p ETH item is the only item in the pattern, and the @p type field > - * is not specified, then both tagged and untagged packets will match the > - * pattern. > + * The field @p has_vlan can be used to match specific packet types, instead > + * of using the @p type field. > + * This can be used to match any type of tagged packets. If I understand well, these two sentences could be merged in one: The field @p has_vlan can be used to match tagged packets, instead of using the @p type field. > + * If the @p type and @p has_vlan fields are not specified, then both tagged > + * and untagged packets will match the pattern. OK [...] > + * The field @p has_more_vlan can be used to match specific packet types, > + * instead of using the @p inner_type field. > + * This can be used to match any type of tagged packets. Here as well, "specific" can be replaced with "QinQ" or "inner tagged". > + * If the @p inner_type and @p has_more_vlan fields are not specified, > + * then any tagged packets will match the pattern. OK
