02/10/2020 20:21, Ranjit Menon: > On 10/1/2020 3:55 PM, Narcisa Ana Maria Vasile wrote: > > From: Narcisa Vasile <navas...@microsoft.com> > > > > The Windows netuio kernel driver provides the DPDK userspace application > > with direct access to hardware, by mapping the HW registers in userspace > > and allowing read/write operations from/to the device > > configuration space. > > > > Two IOCTLs are defined by the netuio interface: > > * IOCTL_NETUIO_MAP_HW_INTO_USERSPACE > > - used for mapping the device registers into userspace > > * IOCTL_NETUIO_PCI_CONFIG_IO > > - used to read/write from/into the device configuration space > > > > Note: > > Requests to map the device BARs into userspace need to be processed > > in the thread context of the process that initiated the mapping request. > > Otherwise, the BARs might end up mapped into an arbitrary process > > address space. > > EvtIoInCallerContext is used to ensure the requests are handled > > in the right user thread context. Other requests (PCI config) > > are sent back to the framework and processed by the EvtIoDeviceControl > > callback. > > > > Cc: Harini Ramakrishnan <harini.ramakrish...@microsoft.com> > > Cc: Omar Cardona <ocard...@microsoft.com> > > Cc: Dmitry Malloy <dmit...@microsoft.com> > > Signed-off-by: Narcisa Vasile <navas...@microsoft.com> > > We'll need to do a code-style cleanup at some point, but for now: > > Reviewed-by: Ranjit Menon <ranjit.me...@intel.com> > Acked-by: Ranjit Menon <ranjit.me...@intel.com>
For info, Reviewed-by is stronger because it means you carefully checked the code. I drop Acked-by redundancy in this case. With Reviewed-by: Dmitry Kozlyuk <dmitry.kozl...@gmail.com> Applied, thanks For next patches, I would prefer a prefix "kmods" in the subject: --subject-prefix='kmods PATCH'