On 14/10/20 09:25 +0300, Andrew Rybchenko wrote: > On 10/13/20 7:56 PM, Ferruh Yigit wrote: > > Prefix static function and variables with 'eth_dev'. > > > > For some 'rte_' prefix dropped, and for others 'eth_dev' added. > > This is useful to differentiate public and static function/variables. > > > > The cleanup is good to for having consistent naming to help new > > additions naming. > > > > No functional change, only naming. > > > > Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com> > > --- > > I think this renaming is good idea but not sure if it worth the noise > > it creates in the git history, since the change is mostly cosmetic. > > I like the idea and say yes. Noise on git history is not > the main problem here. Fixes backporting will be a problem. > Anyway we should do it one day and I see no single reason > why not now. > > Acked-by: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru>
Same for me: I think this is a real improvement that trumps issues with git noise and backporting problems. As it should happen at some point anyway, maybe it would be better to try and have it in 20.11 release? That way future bug fixes will at least be based on this naming and should be easier to backport. Acked-by: Gaetan Rivet <gr...@u256.net> -- Gaëtan
