Hi
> -----Original Message-----
> From: Thomas Monjalon <tho...@monjalon.net>
> Sent: Monday, October 12, 2020 5:33 PM
> To: Guy Kaneti <g...@marvell.com>
> Cc: or...@mellanox.com; Jerin Jacob Kollanukkaran <jer...@marvell.com>;
> Nithin Kumar Dabilpuram <ndabilpu...@marvell.com>; m...@ashroe.eu;
> nhor...@tuxdriver.com; bruce.richard...@intel.com;
> anatoly.bura...@intel.com; john.mcnam...@intel.com;
> marko.kovace...@intel.com; dev@dpdk.org; Smadar Fuks
> <smad...@marvell.com>; Dovrat Zifroni <dov...@marvell.com>; Liron Himi
> <lir...@marvell.com>
> Subject: [EXT] Re: [dpdk-dev] [PATCH v2 2/4] regex/octeontx2: add build
> infra and device support
>
> External Email
>
> ----------------------------------------------------------------------
> 12/10/2020 13:31, g...@marvell.com:
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1118,6 +1118,9 @@ F: drivers/regex/mlx5/
> > F: doc/guides/regexdevs/mlx5.rst
> > F: doc/guides/regexdevs/features/mlx5.ini
> >
> > +Marvell OCTEON TX2 regex
> > +M: Guy Kaneti <g...@marvell.com>
> > +F: drivers/regex/octeontx2/
> >
>
> A blank line is missing.
> Please sort in alphabetical order.
Will fix
>
> > --- /dev/null
> > +++ b/drivers/regex/octeontx2/rte_pmd_octeontx2_regex_version.map
> > @@ -0,0 +1,3 @@
> > +DPDK_20.08 {
> > + local: *;
> > +};
>
> Should be DPDK_21
Will fix
>
> > --- a/meson_options.txt
> > +++ b/meson_options.txt
> > +option('ree_compiler_sdk', type: 'string', value: '',
> > + description: 'path to REE compiler SDK optional library for regex
> device')
>
> Is this SDK specific to Marvell or octeontx2?
> If yes, it should appear here.
Yes, it is specific to Marvell.
>
> Why this SDK requires setting the path manually?
> Well designed libs should use pkg-config.
>
>
