On 2015/07/02 20:11, Bruce Richardson wrote: > On Tue, Jun 30, 2015 at 05:24:25PM +0900, Tetsuya Mukawa wrote: >> From: "Tetsuya.Mukawa" <mukawa at igel.co.jp> >> >> The patch consolidates below functions, and implemented in common >> eal code. >> - pci_map_resource() >> - pci_unmap_resource() >> >> Signed-off-by: Tetsuya Mukawa <mukawa at igel.co.jp> >> --- >> lib/librte_eal/bsdapp/eal/eal_pci.c | 22 ---------------- >> lib/librte_eal/common/eal_common_pci.c | 39 ++++++++++++++++++++++++++++ >> lib/librte_eal/common/include/rte_pci.h | 11 ++++++++ >> lib/librte_eal/linuxapp/eal/eal_pci.c | 41 >> ------------------------------ >> lib/librte_eal/linuxapp/eal/eal_pci_init.h | 5 ---- >> 5 files changed, 50 insertions(+), 68 deletions(-) >> > <snip> >> diff --git a/lib/librte_eal/common/include/rte_pci.h >> b/lib/librte_eal/common/include/rte_pci.h >> index 0a2ef09..56dcb46 100644 >> --- a/lib/librte_eal/common/include/rte_pci.h >> +++ b/lib/librte_eal/common/include/rte_pci.h >> @@ -364,6 +364,17 @@ int rte_eal_pci_scan(void); >> */ >> int rte_eal_pci_probe(void); >> >> +/** >> + * Map pci resouce. >> + */ >> +void *pci_map_resource(void *requested_addr, int fd, off_t offset, >> + size_t size, int additional_flags); >> + >> +/** >> + * Map pci resouce. >> + */ >> +void pci_unmap_resource(void *requested_addr, size_t size); >> + > These functions should probably be marked "@internal", right?
Yes, it should be. I will fix it. Tetsuya
