Hi, Thanks for the feedback Thomas. Please see my updated patch, I hope it better explains the scope of this work.
Best regards, Georgios On Tue, Oct 6, 2020 at 1:25 AM Thomas Monjalon <tho...@monjalon.net> wrote: > 05/10/2020 19:16, Georgios Katsikas: > > Hi, > > > > What is the conclusion? > > I haven't seen this patch being committed yet. > > You missed updating the file doc/guides/tools/flow-perf.rst > > > > On Thu, Sep 24, 2020 at 3:01 PM Wisam Monther <wis...@nvidia.com> wrote: > > >From: Georgios Katsikas > > > > > > > >* One can now configure the number of rules per batch > > Please develop a bit more what was the previous behaviour > and what you mean by "batch" in this context. > > > > >* Refactored flow_count variable to rules_count as it is related to > the > > > newly > > > >added rules_batch variable > > > >* Added default values to usage function > > > > > > > >Signed-off-by: Georgios Katsikas <katsikas...@gmail.com> > > > > > > Acked-by: Wisam Jaddo <wis...@nvidia.com> > > Wisam, you should not ack if the doc is not updated. > Otherwise you will have to complete the doc update yourself ;) > > >
