> -----Original Message----- > From: Xie, Huawei > Sent: Thursday, July 2, 2015 5:38 PM > To: Ouyang, Changchun; dev at dpdk.org > Cc: Cao, Waterman; Xu, Qian Q > Subject: Re: [PATCH 3/3] vhost: call api to unregister vhost driver > > On 7/2/2015 11:33 AM, Ouyang, Changchun wrote: > > > > /* Start CUSE session. */ > > rte_vhost_driver_session_start(); > > + > > + /* Unregister vhost driver. */ > > + ret = rte_vhost_driver_unregister((char *)&dev_basename); > > + if (ret != 0) > > + rte_exit(EXIT_FAILURE,"vhost driver unregister failure.\n"); > > + > Better remove the above code. > It is duplicated with signal handler and actually > rte_vhost_driver_session_start never returns.
How about call one function to replace the code snippet? I think we need unregister there, it give us a clear example what the vhost lib caller need to do at the ramp down stage. Maybe 'never return' will be changed some day. > > > return 0; > > > > }
