On 10/8/2020 12:49 PM, Sarosh Arif wrote:
Called rte_eth_dev_info_get() in testpmd, to get device info
so that speed capabilities can be printed under "show device info"
Bugzilla ID: 496
Signed-off-by: Sarosh Arif <sarosh.a...@emumba.com>
---
v2:
display all speed capabilities in a single line
remove switch case
v3:
add missing speeds
make a function for displaying speed capabilities
---
app/test-pmd/config.c | 45 ++++++++++++++++++++++++++++++++++++++++++
app/test-pmd/testpmd.h | 1 +
2 files changed, 46 insertions(+)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 30bee3324..95c2798c8 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -507,6 +507,46 @@ static int bus_match_all(const struct rte_bus *bus, const
void *data)
return 0;
}
+void
+device_infos_display_speeds(uint32_t speed_capa)
+{
Can you please make the function static?
<...>
@@ -569,6 +611,9 @@ device_infos_display(const char *identifier)
&mac_addr);
rte_eth_dev_get_name_by_port(port_id, name);
printf("\n\tDevice name: %s", name);
+ rte_eth_dev_info_get(port_id, &dev_info);
It is very unlikely that it will fail but still it can be good add the return
value check
if (rte_eth_dev_info_get(port_id, &dev_info) > 0)
device_infos_display_speeds(dev_info.speed_capa);
+ speed_capa = dev_info.speed_capa;
+ device_infos_display_speeds(speed_capa);
Is the 'speed_capa' variable still needed? Why not directly use
'dev_info.speed_capa'?
printf("\n");
}
}
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index 25a12b14f..0773016f7 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -694,6 +694,7 @@ void nic_stats_clear(portid_t port_id);
void nic_xstats_display(portid_t port_id);
void nic_xstats_clear(portid_t port_id);
void nic_stats_mapping_display(portid_t port_id);
+void device_infos_display_speeds(uint32_t speed_capa);
If function becomes static this deceleration won't be needed.
