> -----Original Message----- > From: McDaniel, Timothy <timothy.mcdan...@intel.com> > Sent: Friday, September 11, 2020 3:26 PM > To: Ray Kinsella <m...@ashroe.eu>; Neil Horman <nhor...@tuxdriver.com> > Cc: dev@dpdk.org; Carrillo, Erik G <erik.g.carri...@intel.com>; Eads, Gage > <gage.e...@intel.com>; Van Haaren, Harry <harry.van.haa...@intel.com>; > jer...@marvell.com > Subject: [PATCH 18/22] event/dlb2: add PMD's token pop public interface > > The PMD uses a public interface to allow applications to > control the token pop mode. Supported token pop modes are > as follows, and they impact core scheduling affinity for > ldb ports. > > AUTO_POP: Pop the CQ tokens immediately after dequeueing. > DELAYED_POP: Pop CQ tokens after (dequeue_depth - 1) events > are released. Supported on load-balanced ports > only. > DEFERRED_POP: Pop the CQ tokens during next dequeue operation. > > Signed-off-by: Timothy McDaniel <timothy.mcdan...@intel.com> > --- > drivers/event/dlb2/meson.build | 5 ++- > drivers/event/dlb2/rte_pmd_dlb2.c | 39 > +++++++++++++++++++++++ > drivers/event/dlb2/rte_pmd_dlb2_event_version.map | 6 ++++ Should rte_pmd_dlb2.h be listed in doc/api/doxy-api-index.md, so it's included in the doxygen docs? Besides that, and the build error related to the experimental tag mentioned in another review, this looks good to me. Thanks, Gage
