> -----Original Message-----
> From: McDaniel, Timothy <timothy.mcdan...@intel.com>
> Sent: Friday, September 11, 2020 3:26 PM
> Cc: dev@dpdk.org; Carrillo, Erik G <erik.g.carri...@intel.com>; Eads, Gage
> <gage.e...@intel.com>; Van Haaren, Harry <harry.van.haa...@intel.com>;
> jer...@marvell.com
> Subject: [PATCH 14/22] event/dlb2: add eventdev start
>
> Add support for the eventdev start entry point.
>
Code looks fine (one whitespace nit below), but it could use a more detailed
commit message -- e.g. describing how the PMD delays port links until
eventdev start time, how the configuration will be reapplied at this time if
this is a reconfiguration scenario, etc.
[...]
> +static int
> +dlb2_eventdev_start(struct rte_eventdev *dev)
> +{
> + struct dlb2_eventdev *dlb2 = dlb2_pmd_priv(dev);
> + struct dlb2_hw_dev *handle = &dlb2->qm_instance;
> + struct dlb2_start_domain_args cfg;
> + int ret, i;
> +
> + rte_spinlock_lock(&dlb2->qm_instance.resource_lock);
> + if (dlb2->run_state != DLB2_RUN_STATE_STOPPED) {
> + DLB2_LOG_ERR("bad state %d for dev_start\n",
> + (int)dlb2->run_state);
> + rte_spinlock_unlock(&dlb2->qm_instance.resource_lock);
> + return -EINVAL;
> + }
> + dlb2->run_state = DLB2_RUN_STATE_STARTING;
Looks like there's a tab between run_state and the equals sign.
Thanks,
Gage
