On Wed, Oct 7, 2020 at 12:41 PM Doherty, Declan <declan.dohe...@intel.com> wrote: > >> @@ -789,33 +781,9 @@ rte_cryptodev_stats_reset(uint8_t dev_id); > >> * the last valid element has it's op field set to > >> * RTE_CRYPTO_OP_TYPE_UNDEFINED. > >> */ > >> - > >> -void > >> +extern void > > Nit: no need for extern. > Hey David, I think the cryptodev API consistently uses extern on nearly > all it's function declarations. I'd proposed we do a separate patchset > which removes extern on all function declarations to make it more > consistent with the rest of DPDKs libraries.
Ok for me. -- David Marchand