On 10/6/2020 4:24 PM, Raslan Darawsheh wrote:
Hi,
-----Original Message-----
From: dev <dev-boun...@dpdk.org> On Behalf Of Xueming Li
Sent: Thursday, September 10, 2020 7:25 AM
To: Matan Azrad <ma...@nvidia.com>; Slava Ovsiienko
<viachesl...@nvidia.com>
Cc: dev@dpdk.org; Asaf Penso <as...@nvidia.com>; sta...@dpdk.org
Subject: [dpdk-dev] [PATCH] net/mlx5: disable flow dump for Verbs flow
There was a segment fault when dump flows with device argument of
dv_flow_en=0. In such case, Verbs flow engine was enabled and fdb
resources were not initialized. It's suggested to use mlx_fs_dump
for Verbs flow dump.
This patch adds verbs engine check, prints warning message and return
gracefully.
Cc: sta...@dpdk.org
Signed-off-by: Xueming Li <xuemi...@nvidia.com>
Can you please provide the fixed commit information?
That is required to figure out which stable tress to backport.
---
drivers/net/mlx5/mlx5_flow.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 4c29898203..5a28b80ee4 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -6268,6 +6268,11 @@ mlx5_flow_dev_dump(struct rte_eth_dev *dev,
struct mlx5_priv *priv = dev->data->dev_private;
struct mlx5_dev_ctx_shared *sh = priv->sh;
+ if (!priv->config.dv_flow_en) {
+ if (fputs("device dv flow disabled\n", file) <= 0)
+ return -errno;
+ return -ENOTSUP;
+ }
return mlx5_devx_cmd_flow_dump(sh->fdb_domain, sh-
rx_domain,
sh->tx_domain, file);
}
--
2.25.1
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
