On 05/10/2020 10:07, Kinsella, Ray wrote:
> A nit and some questions below, thanks Ray K.
>
> On 30/09/2020 22:39, Gage Eads wrote:
>> The stack library was first released in 19.05, and its interfaces have been
>> stable since their initial introduction. This commit promotes the full
>> interface to stable, starting with the 20.11 major version.
>>
>> Signed-off-by: Gage Eads <gage.e...@intel.com>
>> Acked-by: David Marchand <david.march...@redhat.com>
>> ---
>> doc/guides/rel_notes/release_20_11.rst | 3 +++
>> lib/librte_stack/rte_stack.h | 32 --------------------------------
>> lib/librte_stack/rte_stack_lf.h | 2 --
>> lib/librte_stack/rte_stack_std.h | 3 ---
>> lib/librte_stack/rte_stack_version.map | 2 +-
>> 5 files changed, 4 insertions(+), 38 deletions(-)
> NIT: You are missing the v3 in the subject line, doesn't require a fix.
>
[SNIP]
So after chatting with David, it looks like there is no _nice_ way to indicate
that
some inlines are "internal" while others are "public".
Something to look at in future maybe.
>>
>> diff --git a/lib/librte_stack/rte_stack_lf.h
>> b/lib/librte_stack/rte_stack_lf.h
>> index e67630c27..eb106e64e 100644
>> --- a/lib/librte_stack/rte_stack_lf.h
>> +++ b/lib/librte_stack/rte_stack_lf.h
>> @@ -27,7 +27,6 @@
>> * @return
>> * Actual number of objects enqueued.
>> */
>> -__rte_experimental
>
> This looks like an internal function, should it be __rte_internal?
>
>> static __rte_always_inline unsigned int
>> __rte_stack_lf_push(struct rte_stack *s,
>> void * const *obj_table,
>> @@ -66,7 +65,6 @@ __rte_stack_lf_push(struct rte_stack *s,
>> * @return
>> * - Actual number of objects popped.
>> */
>> -__rte_experimental
>
> This looks like an internal function, should it be __rte_internal?
>
>> static __rte_always_inline unsigned int
>> __rte_stack_lf_pop(struct rte_stack *s, void **obj_table, unsigned int n)
>> {
>> diff --git a/lib/librte_stack/rte_stack_std.h
>> b/lib/librte_stack/rte_stack_std.h
>> index 7142cbf8e..ae28add5c 100644
>> --- a/lib/librte_stack/rte_stack_std.h
>> +++ b/lib/librte_stack/rte_stack_std.h
>> @@ -19,7 +19,6 @@
>> * @return
>> * Actual number of objects pushed (either 0 or *n*).
>> */
>> -__rte_experimental
>
> This looks like an internal function, should it be __rte_internal?
>
>> static __rte_always_inline unsigned int
>> __rte_stack_std_push(struct rte_stack *s, void * const *obj_table,
>> unsigned int n)
>> @@ -59,7 +58,6 @@ __rte_stack_std_push(struct rte_stack *s, void * const
>> *obj_table,
>> * @return
>> * Actual number of objects popped (either 0 or *n*).
>> */
>> -__rte_experimental
>
> This looks like an internal function, should it be __rte_internal?
>
>> static __rte_always_inline unsigned int
>> __rte_stack_std_pop(struct rte_stack *s, void **obj_table, unsigned int n)
>> {
>> @@ -94,7 +92,6 @@ __rte_stack_std_pop(struct rte_stack *s, void **obj_table,
>> unsigned int n)
>> * @return
>> * The number of used entries in the stack.
>> */
>> -__rte_experimental
>> static __rte_always_inline unsigned int
>> __rte_stack_std_count(struct rte_stack *s)
>> {
>> diff --git a/lib/librte_stack/rte_stack_version.map
>> b/lib/librte_stack/rte_stack_version.map
>> index 6662679c3..8c4ca0245 100644
>> --- a/lib/librte_stack/rte_stack_version.map
>> +++ b/lib/librte_stack/rte_stack_version.map
>> @@ -1,4 +1,4 @@
>> -EXPERIMENTAL {
>> +DPDK_21 {
>> global:
>>
>> rte_stack_create;
>>
Acked-by: Ray Kinsella <m...@ashroe.eu>
