> -----Original Message-----
> From: dev <dev-boun...@dpdk.org> On Behalf Of Lijun Ou
> Sent: Thursday, September 24, 2020 9:45 PM
> To: wenzhuo...@intel.com; beilei.x...@intel.com;
> adrien.mazarg...@6wind.com; ferruh.yi...@intel.com
> Cc: dev@dpdk.org; linux...@huawei.com
> Subject: [dpdk-dev] [PATCH v4] app/testpmd: fix the default RSS key
> configuration
>
> It use the NIC valid default RSS key instead of the testpmd
> dummy RSS key in the flow configuration when the RSS key is
> not specified in the flow rule. If the NIC RSS key is
> invalid, it will use testpmd dummy RSS key as the default
> key.
>
> Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Lijun Ou <ouli...@huawei.com>
It looks good to me. Thanks.
Reviewed-by: Phil Yang <phil.y...@arm.com>
> ---
> V3->V4:
> -fix checkpatch warning and shorter commit content.
>
> V2->V3:
> -fix checkpatch warning.
>
> V1->V2:
> -fix the commit.
> ---
> app/test-pmd/cmdline_flow.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 6263d30..e6648da 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -4312,6 +4312,7 @@ parse_vc_action_rss(struct context *ctx, const
> struct token *token,
> action_rss_data->queue[i] = i;
> if (!port_id_is_invalid(ctx->port, DISABLED_WARN) &&
> ctx->port != (portid_t)RTE_PORT_ALL) {
> + struct rte_eth_rss_conf rss_conf = {0};
> struct rte_eth_dev_info info;
> int ret2;
>
> @@ -4322,6 +4323,13 @@ parse_vc_action_rss(struct context *ctx, const
> struct token *token,
> action_rss_data->conf.key_len =
> RTE_MIN(sizeof(action_rss_data->key),
> info.hash_key_size);
> +
> + rss_conf.rss_key_len = sizeof(action_rss_data->key);
> + rss_conf.rss_key = action_rss_data->key;
> + ret2 = rte_eth_dev_rss_hash_conf_get(ctx->port,
> &rss_conf);
> + if (ret2 != 0)
> + return ret2;
> + action_rss_data->conf.key = rss_conf.rss_key;
> }
> action->conf = &action_rss_data->conf;
> return ret;
> --
> 2.7.4
