28/09/2020 11:04, Ferruh Yigit:
> On 9/27/2020 4:16 AM, Min Hu (Connor) wrote:
> > From: Huisong Li <lihuis...@huawei.com>
> >
> > Currently, base and nb_queue in the tc_rxq and tc_txq information
> > of queue and TC mapping on both TX and RX paths are uint8_t.
> > However, these data will be truncated when queue number under a TC
> > is greater than 256. So it is necessary for base and nb_queue to
> > change from uint8_t to uint16_t.
[...]
> > --- a/lib/librte_ethdev/rte_ethdev.h
> > +++ b/lib/librte_ethdev/rte_ethdev.h
> > struct rte_eth_dcb_tc_queue_mapping {
> > /** rx queues assigned to tc per Pool */
> > struct {
> > - uint8_t base;
> > - uint8_t nb_queue;
> > + uint16_t base;
> > + uint16_t nb_queue;
> > } tc_rxq[ETH_MAX_VMDQ_POOL][ETH_DCB_NUM_TCS];
> > /** rx queues assigned to tc per Pool */
> > struct {
> > - uint8_t base;
> > - uint8_t nb_queue;
> > + uint16_t base;
> > + uint16_t nb_queue;
> > } tc_txq[ETH_MAX_VMDQ_POOL][ETH_DCB_NUM_TCS];
> > };
> >
> >
>
> cc'ed tech-board,
>
> The patch breaks the ethdev ABI without a deprecation notice from previous
> release(s).
>
> It is increasing the storage size of the fields to support more than 255
> queues.
Yes queues are in 16-bit range.
> Since the ethdev library already heavily breaks the ABI this release, I am
> for
> getting this patch, instead of waiting for one more year for the update.
>
> Can you please review the patch, is there any objection to proceed with it?
Acked-by: Thomas Monjalon <tho...@monjalon.net>
