> -----Original Message----- > From: Doherty, Declan > Sent: Friday, January 30, 2015 12:42 PM > To: Wodkowski, PawelX; Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] Added missing extern 'C' decls in mode4 header > files > > On 30/01/15 10:56, Wodkowski, PawelX wrote: > >> -----Original Message----- > >> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > >> Sent: Friday, January 30, 2015 11:21 AM > >> To: Wodkowski, PawelX > >> Cc: dev at dpdk.org > >> Subject: Re: [dpdk-dev] [PATCH] Added missing extern 'C' decls in mode4 > header > >> files > >> > >> Hi Pawel, > >> > >>> Signed-off-by: Pawel Wodkowski <pawelx.wodkowski at intel.com> > >>> --- > >>> lib/librte_pmd_bond/rte_eth_bond_8023ad.h | 8 ++++++++ > >>> lib/librte_pmd_bond/rte_eth_bond_8023ad_private.h | 8 ++++++++ > >> > >> Why adding extern C in a private header file? > >> > >> -- > >> Thomas > > > > To be consistent with rte_eth_bond_private.h where it is included. > > > > > > We only need the decls on the public headers exported by the > librte_pmd_bond makefile, so there is no need to modify > rte_eth_bond_private.h as it should never be linked to directly by > external code.
I modified rte_eth_bond_8023ad_private.h not rte_eth_bond_private.h. In rte_eth_bond_private.h those declarations are present already. If so those declarations should be removed from rte_eth_bond_private.h. I can do this in v2 if you accept this.
