Hi,
> -----Original Message-----
> From: Thomas Monjalon <tho...@monjalon.net>
> Sent: Monday, September 28, 2020 7:42
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yi...@intel.com>; arybche...@solarflare.com; John
> W. Linville <linvi...@tuxdriver.com>; Loftus, Ciara <ciara.lof...@intel.com>;
> Zhang, Qi Z <qi.z.zh...@intel.com>; Shepard Siegel
> <shepard.sie...@atomicrules.com>; Ed Czeck <ed.cz...@atomicrules.com>;
> John Miller <john.mil...@atomicrules.com>; Igor Russkikh
> <igor.russk...@aquantia.com>; Pavel Belous <pavel.bel...@aquantia.com>;
> Steven Webster <steven.webs...@windriver.com>; Matt Peters
> <matt.pet...@windriver.com>; Somalapuram Amaranath
> <asoma...@amd.com>; Rasesh Mody <rm...@marvell.com>; Shahed
> Shaikh <shsha...@marvell.com>; Ajit Khaparde
> <ajit.khapa...@broadcom.com>; Somnath Kotur
> <somnath.ko...@broadcom.com>; Chas Williams <ch...@att.com>; Wei Hu
> (Xavier) <xavier.hu...@huawei.com>; Rahul Lakkireddy
> <rahul.lakkire...@chelsio.com>; Hemant Agrawal
> <hemant.agra...@nxp.com>; Sachin Saxena <sachin.sax...@oss.nxp.com>;
> Guo, Jia <jia....@intel.com>; Wang, Haiyue <haiyue.w...@intel.com>;
> Marcin Wojtas <m...@semihalf.com>; Michal Krawczyk <m...@semihalf.com>;
> Guy Tzalik <gtza...@amazon.com>; Evgeny Schemeilin
> <evge...@amazon.com>; Igor Chauskin <igo...@amazon.com>;
> Gagandeep Singh <g.si...@nxp.com>; John Daley <johnd...@cisco.com>;
> Hyong Youb Kim <hyon...@cisco.com>; Gaetan Rivet <gr...@u256.net>;
> Wang, Xiao W <xiao.w.w...@intel.com>; Ziyang Xuan
> <xuanziya...@huawei.com>; Xiaoyun Wang
> <cloud.wangxiao...@huawei.com>; Guoyang Zhou
> <zhouguoy...@huawei.com>; Min Hu (Connor) <humi...@huawei.com>;
> Yisen Zhuang <yisen.zhu...@huawei.com>; Xing, Beilei
> <beilei.x...@intel.com>; Wu, Jingjing <jingjing...@intel.com>; Yang, Qiming
> <qiming.y...@intel.com>; Alfredo Cardigliano <cardigli...@ntop.org>; Xu,
> Rosen <rosen...@intel.com>; Shijith Thotton <sthot...@marvell.com>;
> Srisivasubramanian Srinivasan <sriniva...@marvell.com>; Jakub Grajciar
> <jgraj...@cisco.com>; Matan Azrad <ma...@nvidia.com>; Shahaf Shuler
> <shah...@nvidia.com>; Viacheslav Ovsiienko <viachesl...@nvidia.com>;
> Zyta Szpak <z...@semihalf.com>; Liron Himi <lir...@marvell.com>; Stephen
> Hemminger <sthem...@microsoft.com>; K. Y. Srinivasan
> <k...@microsoft.com>; Haiyang Zhang <haiya...@microsoft.com>; Long Li
> <lon...@microsoft.com>; Martin Spinler <spin...@cesnet.cz>; Heinrich Kuhn
> <heinrich.k...@netronome.com>; Harman Kalra <hka...@marvell.com>;
> Jerin Jacob <jer...@marvell.com>; Nithin Dabilpuram
> <ndabilpu...@marvell.com>; Kiran Kumar K <kirankum...@marvell.com>;
> Akhil Goyal <akhil.go...@nxp.com>; Singh, Jasvinder
> <jasvinder.si...@intel.com>; Dumitrescu, Cristian
> <cristian.dumitre...@intel.com>; Wiles, Keith <keith.wi...@intel.com>;
> Maciej Czekaj <mcze...@marvell.com>; Maxime Coquelin
> <maxime.coque...@redhat.com>; Xia, Chenbo <chenbo....@intel.com>;
> Wang, Zhihong <zhihong.w...@intel.com>; Yong Wang
> <yongw...@vmware.com>
> Subject: [PATCH v2 02/25] ethdev: allow drivers to return error on close
>
> The device operation .dev_close was returning void.
> This driver interface is changed to return an int.
>
> Note that the API rte_eth_dev_close() is still returning void,
> although a deprecation notice is pending to change it as well.
>
> Signed-off-by: Thomas Monjalon <tho...@monjalon.net>
> ---
> app/test/virtual_pmd.c | 6 ++++--
> drivers/net/af_packet/rte_eth_af_packet.c | 3 ++-
> drivers/net/af_xdp/rte_eth_af_xdp.c | 4 +++-
> drivers/net/ark/ark_ethdev.c | 6 ++++--
> drivers/net/atlantic/atl_ethdev.c | 6 ++++--
> drivers/net/avp/avp_ethdev.c | 5 +++--
> drivers/net/axgbe/axgbe_ethdev.c | 5 +++--
> drivers/net/bnx2x/bnx2x_ethdev.c | 4 +++-
> drivers/net/bnxt/bnxt_ethdev.c | 4 +++-
> drivers/net/bnxt/bnxt_reps.c | 3 ++-
> drivers/net/bnxt/bnxt_reps.h | 2 +-
> drivers/net/bonding/eth_bond_private.h | 2 +-
> drivers/net/bonding/rte_eth_bond_pmd.c | 4 +++-
> drivers/net/cxgbe/cxgbe_ethdev.c | 10 ++++++----
> drivers/net/cxgbe/cxgbe_pfvf.h | 2 +-
> drivers/net/dpaa/dpaa_ethdev.c | 4 +++-
> drivers/net/dpaa2/dpaa2_ethdev.c | 6 ++++--
> drivers/net/e1000/em_ethdev.c | 6 ++++--
> drivers/net/e1000/igb_ethdev.c | 12 ++++++++----
> drivers/net/ena/ena_ethdev.c | 6 ++++--
> drivers/net/enetc/enetc_ethdev.c | 4 +++-
> drivers/net/enic/enic_ethdev.c | 4 +++-
> drivers/net/enic/enic_vf_representor.c | 5 +++--
> drivers/net/failsafe/failsafe_ops.c | 3 ++-
> drivers/net/fm10k/fm10k_ethdev.c | 4 +++-
> drivers/net/hinic/hinic_pmd_ethdev.c | 6 ++++--
> drivers/net/hns3/hns3_ethdev.c | 6 ++++--
> drivers/net/hns3/hns3_ethdev_vf.c | 6 ++++--
> drivers/net/i40e/i40e_ethdev.c | 5 +++--
> drivers/net/i40e/i40e_ethdev_vf.c | 5 +++--
> drivers/net/iavf/iavf_ethdev.c | 6 ++++--
> drivers/net/ice/ice_dcf_ethdev.c | 6 ++++--
> drivers/net/ice/ice_ethdev.c | 6 ++++--
> drivers/net/igc/igc_ethdev.c | 6 ++++--
> drivers/net/ionic/ionic_ethdev.c | 10 ++++++----
> drivers/net/ipn3ke/ipn3ke_representor.c | 4 +++-
> drivers/net/ixgbe/ixgbe_ethdev.c | 11 +++++++----
> drivers/net/kni/rte_eth_kni.c | 4 +++-
> drivers/net/liquidio/lio_ethdev.c | 4 +++-
> drivers/net/memif/rte_eth_memif.c | 4 +++-
> drivers/net/mlx4/mlx4.c | 3 ++-
> drivers/net/mlx5/mlx5.c | 9 +++++----
> drivers/net/mlx5/mlx5.h | 2 +-
> drivers/net/mvneta/mvneta_ethdev.c | 4 +++-
> drivers/net/mvpp2/mrvl_ethdev.c | 4 +++-
> drivers/net/netvsc/hn_ethdev.c | 4 +++-
> drivers/net/nfb/nfb_ethdev.c | 4 +++-
> drivers/net/nfp/nfp_net.c | 6 ++++--
> drivers/net/octeontx/octeontx_ethdev.c | 4 +++-
> drivers/net/octeontx2/otx2_ethdev.c | 5 +++--
> drivers/net/pcap/rte_eth_pcap.c | 3 ++-
> drivers/net/pfe/pfe_ethdev.c | 8 +++++---
> drivers/net/qede/qede_ethdev.c | 4 +++-
> drivers/net/sfc/sfc_ethdev.c | 4 +++-
> drivers/net/softnic/rte_eth_softnic.c | 4 ++--
> drivers/net/szedata2/rte_eth_szedata2.c | 4 +++-
> drivers/net/tap/rte_eth_tap.c | 4 +++-
> drivers/net/thunderx/nicvf_ethdev.c | 4 +++-
> drivers/net/vhost/rte_eth_vhost.c | 6 ++++--
> drivers/net/virtio/virtio_ethdev.c | 6 ++++--
> drivers/net/vmxnet3/vmxnet3_ethdev.c | 6 ++++--
> lib/librte_ethdev/rte_ethdev_driver.h | 2 +-
> 62 files changed, 206 insertions(+), 103 deletions(-)
>
> static int
> diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c
> b/drivers/net/ipn3ke/ipn3ke_representor.c
> index b673c49149..d49abbf758 100644
> --- a/drivers/net/ipn3ke/ipn3ke_representor.c
> +++ b/drivers/net/ipn3ke/ipn3ke_representor.c
> @@ -208,7 +208,7 @@ ipn3ke_rpst_dev_stop(struct rte_eth_dev *dev)
> }
> }
>
> -static void
> +static int
> ipn3ke_rpst_dev_close(struct rte_eth_dev *dev)
> {
> struct ipn3ke_hw *hw = IPN3KE_DEV_PRIVATE_TO_HW(dev);
> @@ -221,6 +221,8 @@ ipn3ke_rpst_dev_close(struct rte_eth_dev *dev)
> /* Disable the RX path */
> ipn3ke_xmac_rx_disable(hw, rpst->port_id, 0);
> }
> +
> + return 0;
> }
>
> /*
> 2.28.0
For net/ipn3ke
Reviewed-by: Rosen Xu <rosen...@intel.com>
