[dpdk-dev] [PATCH v2 20/25] drivers/net: remove redundant MAC addresses freeing

[Thomas Monjalon]

The MAC addresses array is already freed by rte_eth_dev_release_port().
The redundant freeing can be removed from the PMD port closing functions.

Signed-off-by: Thomas Monjalon <tho...@monjalon.net>
Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com>
---
 drivers/net/ark/ark_ethdev.c            | 3 ---
 drivers/net/hinic/hinic_pmd_ethdev.c    | 3 ---
 drivers/net/ice/ice_ethdev.c            | 3 ---
 drivers/net/nfb/nfb_ethdev.c            | 3 ---
 drivers/net/szedata2/rte_eth_szedata2.c | 3 ---
 5 files changed, 15 deletions(-)

diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index 3e96445fdb..e3b1347769 100644
--- a/drivers/net/ark/ark_ethdev.c
+++ b/drivers/net/ark/ark_ethdev.c
@@ -705,9 +705,6 @@ eth_ark_dev_close(struct rte_eth_dev *dev)
                dev->data->rx_queues[i] = 0;
        }
 
-       rte_free(dev->data->mac_addrs);
-       dev->data->mac_addrs = 0;
-
        return 0;
 }
 
diff --git a/drivers/net/hinic/hinic_pmd_ethdev.c 
b/drivers/net/hinic/hinic_pmd_ethdev.c
index 1b175aeace..c5b06fae73 100644
--- a/drivers/net/hinic/hinic_pmd_ethdev.c
+++ b/drivers/net/hinic/hinic_pmd_ethdev.c
@@ -3228,9 +3228,6 @@ static int hinic_dev_uninit(struct rte_eth_dev *dev)
 
        rte_free(nic_dev->mc_list);
 
-       rte_free(dev->data->mac_addrs);
-       dev->data->mac_addrs = NULL;
-
        return HINIC_OK;
 }
 
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 96159c92f2..73af19ce81 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -2467,9 +2467,6 @@ ice_dev_close(struct rte_eth_dev *dev)
        dev->rx_pkt_burst = NULL;
        dev->tx_pkt_burst = NULL;
 
-       rte_free(dev->data->mac_addrs);
-       dev->data->mac_addrs = NULL;
-
        /* disable uio intr before callback unregister */
        rte_intr_disable(intr_handle);
 
diff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net/nfb/nfb_ethdev.c
index 7ee7294143..a9a8bc878d 100644
--- a/drivers/net/nfb/nfb_ethdev.c
+++ b/drivers/net/nfb/nfb_ethdev.c
@@ -236,9 +236,6 @@ nfb_eth_dev_close(struct rte_eth_dev *dev)
        }
        dev->data->nb_tx_queues = 0;
 
-       rte_free(dev->data->mac_addrs);
-       dev->data->mac_addrs = NULL;
-
        return 0;
 }
 
diff --git a/drivers/net/szedata2/rte_eth_szedata2.c 
b/drivers/net/szedata2/rte_eth_szedata2.c
index 7e9fafdcf7..0eecec1e8c 100644
--- a/drivers/net/szedata2/rte_eth_szedata2.c
+++ b/drivers/net/szedata2/rte_eth_szedata2.c
@@ -1181,9 +1181,6 @@ eth_dev_close(struct rte_eth_dev *dev)
        }
        dev->data->nb_tx_queues = 0;
 
-       rte_free(dev->data->mac_addrs);
-       dev->data->mac_addrs = NULL;
-
        return 0;
 }
 
-- 
2.28.0