> -----Original Message-----
> From: Bruce Richardson <bruce.richard...@intel.com>
> Sent: Wednesday, September 23, 2020 3:59 PM
> To: Juraj Linkeš <juraj.lin...@pantheon.tech>
> Cc: ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com;
> phil.y...@arm.com; vcchu...@amazon.com; dharmik.thak...@arm.com;
> jerinjac...@gmail.com; hemant.agra...@nxp.com; dev@dpdk.org
> Subject: Re: [RFC PATCH 2/2] build: disable drivers from file
>
> On Wed, Sep 23, 2020 at 03:19:21PM +0200, Juraj Linkeš wrote:
> > Add the capability to specify which drivers will NOT be build in a file.
> >
> > Signed-off-by: Juraj Linkeš <juraj.lin...@pantheon.tech>
> > ---
> > .../arm/{ => armada}/arm64_armada_linux_gcc | 2 +-
> > config/arm/armada/meson.build | 31 +++++++++++++++++++
> > drivers/meson.build | 13 +++++---
> > 3 files changed, 41 insertions(+), 5 deletions(-) rename
> > config/arm/{ => armada}/arm64_armada_linux_gcc (93%) create mode
> > 100644 config/arm/armada/meson.build
> >
> > diff --git a/config/arm/arm64_armada_linux_gcc
> > b/config/arm/armada/arm64_armada_linux_gcc
> > similarity index 93%
> > rename from config/arm/arm64_armada_linux_gcc rename to
> > config/arm/armada/arm64_armada_linux_gcc
> > index fa40c0398..8b4b5c8ad 100644
> > --- a/config/arm/arm64_armada_linux_gcc
> > +++ b/config/arm/armada/arm64_armada_linux_gcc
> > @@ -14,4 +14,4 @@ cpu = 'armv8-a'
> > endian = 'little'
> >
> > [properties]
> > -implementor_id = '0x56'
> > +machine = 'armada'
> > diff --git a/config/arm/armada/meson.build
> > b/config/arm/armada/meson.build new file mode 100644 index
> > 000000000..22fdce5fe
> > --- /dev/null
> > +++ b/config/arm/armada/meson.build
> > @@ -0,0 +1,31 @@
> > +flags = {
> > + 'common': [
> > + ['RTE_CACHE_LINE_SIZE', 64],
> > + ['RTE_MACHINE', '"armv8a"'],
> > + ['CONFIG_RTE_LIBRTE_DPAA_BUS=n', false],
> > + ['CONFIG_RTE_LIBRTE_COMMON_DPAAX=n', false],
> > + ['CONFIG_RTE_LIBRTE_FSLMC_BUS=n', false],
> > + ['CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL=n', false],
> > + ['CONFIG_RTE_LIBRTE_DPAA2_PMD=n', false],
> > + ['CONFIG_RTE_LIBRTE_DPAA_BUS=n', false],
> > + ['CONFIG_RTE_LIBRTE_DPAA_MEMPOOL=n', false],
> > + ['CONFIG_RTE_LIBRTE_DPAA_PMD=n', false],
> > + ['CONFIG_RTE_LIBRTE_PMD_DPAA_EVENTDEV=n', false],
> > + ['CONFIG_RTE_LIBRTE_PMD_DPAA_SEC=n', false],
> > + ['CONFIG_RTE_LIBRTE_PMD_CAAM_JR=n', false],
> > + ['CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV=n', false],
> > + ['CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC=n', false],
> > + ['CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF_RAWDEV=n',
> false],
> > + ['CONFIG_RTE_LIBRTE_PMD_DPAA2_QDMA_RAWDEV=n',
> false],
> > + ['CONFIG_RTE_LIBRTE_PFE_PMD=n', false],
> > + ['CONFIG_RTE_LIBRTE_ENETC_PMD=n', false],
> > + ['CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=n', false],
> > + ['CONFIG_RTE_LIBRTE_VHOST_NUMA=n', false]
> > + ],
>
> Rather than setting a list of flags like this make-style, why not have a
> disabled-
> drivers setting, and add that to any user-provided ones? It would save making
> any changes to the drivers/meson.build file, and therefore be a lot cleaner.
> It
> would also allow using wildcards etc. to disable whole classes of drivers
>
I didn't think of this, thanks for the suggestion, that's much better.
