>-----Original Message----- >From: dev <dev-boun...@dpdk.org> On Behalf Of Stephen Hemminger >Sent: Thursday, September 10, 2020 7:46 PM >To: Tejasree Kondoj <ktejas...@marvell.com> >Cc: Akhil Goyal <akhil.go...@nxp.com>; Radu Nicolau ><radu.nico...@intel.com>; Declan Doherty <declan.dohe...@intel.com>; Ori >Kam <or...@mellanox.com>; NBU-Contact-Thomas Monjalon ><tho...@monjalon.net>; Ferruh Yigit <ferruh.yi...@intel.com>; Andrew >Rybchenko <arybche...@solarflare.com>; Jerin Jacob <jer...@marvell.com>; >Narayana Prasad <pathr...@marvell.com>; Anoob Joseph ><ano...@marvell.com>; dev@dpdk.org >Subject: Re: [dpdk-dev] [PATCH] ethdev: add security flow item > >On Thu, 10 Sep 2020 22:14:41 +0530 >Tejasree Kondoj <ktejas...@marvell.com> wrote: > >> Introduce a new item type RTE_FLOW_ITEM_TYPE_SECURITY to distinguish >> plain packets from IPsec decrypted plain packets. >> >> Signed-off-by: Tejasree Kondoj <ktejas...@marvell.com> > >Please provide an implementation, API's without any driver support should not >be >accepted. > >Also, we need a test for this.
+1 Also, I think the word SECURITY is too high-level, and if specifically you mention here an item for IPSec, perhaps you can consider renaming.