W dniu 08.09.2020 o 12:22, Sarosh Arif pisze:
> rte_mempool_get_bulk is used to get bufs/many_bufs from the pool,
> but at some locations when test fails the bufs/many_bufs are
> not returned back to the pool.
> Due to this, multiple executions of distributor_autotest gives the
> following error message: Error getting mbufs from pool.
> To resolve this issue rte_mempool_put_bulk is used whenever the test
> fails and returns.
>
> Signed-off-by: Sarosh Arif <sarosh.a...@emumba.com>
> ---
> v2:
> remove double freeing of mbufs
> v3:
> resubmit to run the tests again
> ---
> app/test/test_distributor.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c
> index ba1f81cf8..1a893a7d9 100644
> --- a/app/test/test_distributor.c
> +++ b/app/test/test_distributor.c
> @@ -128,6 +128,7 @@ sanity_test(struct worker_params *wp, struct rte_mempool
> *p)
> printf("Line %d: Error, not all packets flushed. "
> "Expected %u, got %u\n",
> __LINE__, BURST, total_packet_count());
> + rte_mempool_put_bulk(p, (void *)bufs, BURST);
> return -1;
> }
>
> @@ -153,6 +154,7 @@ sanity_test(struct worker_params *wp, struct rte_mempool
> *p)
> printf("Line %d: Error, not all packets flushed. "
> "Expected %u, got %u\n",
> __LINE__, BURST, total_packet_count());
> + rte_mempool_put_bulk(p, (void *)bufs, BURST);
> return -1;
> }
>
> @@ -179,6 +181,7 @@ sanity_test(struct worker_params *wp, struct rte_mempool
> *p)
> printf("Line %d: Error, not all packets flushed. "
> "Expected %u, got %u\n",
> __LINE__, BURST, total_packet_count());
> + rte_mempool_put_bulk(p, (void *)bufs, BURST);
> return -1;
> }
>
> @@ -233,6 +236,7 @@ sanity_test(struct worker_params *wp, struct rte_mempool
> *p)
> if (num_returned != BIG_BATCH) {
> printf("line %d: Missing packets, expected %d\n",
> __LINE__, num_returned);
> + rte_mempool_put_bulk(p, (void *)many_bufs, BIG_BATCH);
> return -1;
> }
>
> @@ -247,6 +251,7 @@ sanity_test(struct worker_params *wp, struct rte_mempool
> *p)
>
> if (j == BIG_BATCH) {
> printf("Error: could not find source packet #%u\n", i);
> + rte_mempool_put_bulk(p, (void *)many_bufs, BIG_BATCH);
> return -1;
> }
> }
Acked-by: Lukasz Wojciechowski <l.wojciec...@partner.samsung.com>
--
Lukasz Wojciechowski
Principal Software Engineer
Samsung R&D Institute Poland
Samsung Electronics
Office +48 22 377 88 25
l.wojciec...@partner.samsung.com
