[dpdk-dev] [PATCH 5/7] net/virtio: check protocol feature in user backend

[Maxime Coquelin]

When sending set status message, move protocol feature check
to vhost_user to be compatible with different backend types.

Signed-off-by: Maxime Coquelin <maxime.coque...@redhat.com>
---
 drivers/net/virtio/virtio_user/vhost_user.c      | 6 +++++-
 drivers/net/virtio/virtio_user/virtio_user_dev.c | 7 -------
 2 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/drivers/net/virtio/virtio_user/vhost_user.c 
b/drivers/net/virtio/virtio_user/vhost_user.c
index 12b6c7dbcf..ef290c357b 100644
--- a/drivers/net/virtio/virtio_user/vhost_user.c
+++ b/drivers/net/virtio/virtio_user/vhost_user.c
@@ -277,9 +277,13 @@ vhost_user_sock(struct virtio_user_dev *dev,
        msg.size = 0;
 
        switch (req) {
+       case VHOST_USER_GET_STATUS:
+               if (!(dev->protocol_features &
+                               (1ULL << VHOST_USER_PROTOCOL_F_STATUS)))
+                       return 0;
+               /* Fallthrough */
        case VHOST_USER_GET_FEATURES:
        case VHOST_USER_GET_PROTOCOL_FEATURES:
-       case VHOST_USER_GET_STATUS:
                need_reply = 1;
                break;
 
diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c 
b/drivers/net/virtio/virtio_user/virtio_user_dev.c
index 753611ef42..97baa243cd 100644
--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
@@ -838,9 +838,6 @@ virtio_user_send_status_update(struct virtio_user_dev *dev, 
uint8_t status)
        enum virtio_user_backend_type backend_type =
                                virtio_user_backend_type(dev->path);
 
-       if (!(dev->protocol_features & (1ULL << VHOST_USER_PROTOCOL_F_STATUS)))
-               return 0;
-
        if (backend_type == VIRTIO_USER_BACKEND_VHOST_USER)
                ret = dev->ops->send_request(dev,
                                VHOST_USER_SET_STATUS, &arg);
@@ -867,13 +864,9 @@ virtio_user_update_status(struct virtio_user_dev *dev)
        enum virtio_user_backend_type backend_type =
                                virtio_user_backend_type(dev->path);
 
-       /* Vhost-user only for now */
        if (backend_type != VIRTIO_USER_BACKEND_VHOST_USER)
                return 0;
 
-       if (!(dev->protocol_features & (1UL << VHOST_USER_PROTOCOL_F_STATUS)))
-               return 0;
-
        err = dev->ops->send_request(dev, VHOST_USER_GET_STATUS, &ret);
        if (err) {
                PMD_INIT_LOG(ERR, "VHOST_USER_GET_STATUS failed (%d): %s", err,
-- 
2.26.2