> -----Original Message----- > From: Guo, Jia <jia....@intel.com> > Sent: Wednesday, September 9, 2020 1:16 PM > To: Zhang, Qi Z <qi.z.zh...@intel.com> > Cc: Guo, Junfeng <junfeng....@intel.com>; Zhang, AlvinX > <alvinx.zh...@intel.com>; dev@dpdk.org; Xing, Beilei <beilei.x...@intel.com> > Subject: RE: [PATCH v3] net/iavf: refactor RSS > > Acked-by: Jeff Guo <jia....@intel.com> > > Best regards, > Jeff Guo > > > -----Original Message----- > > From: Zhang, Qi Z <qi.z.zh...@intel.com> > > Sent: Wednesday, September 9, 2020 1:16 PM > > To: Guo, Jia <jia....@intel.com> > > Cc: Guo, Junfeng <junfeng....@intel.com>; Zhang, AlvinX > > <alvinx.zh...@intel.com>; dev@dpdk.org; Xing, Beilei > > <beilei.x...@intel.com>; Zhang, Qi Z <qi.z.zh...@intel.com> > > Subject: [PATCH v3] net/iavf: refactor RSS > > > > Current RSS implementation is not easy to scale and maintain. > > The patch refactor the code base on below design: > > > > 1. iavf_pattern_match_item->input_set_mask is the superset of > > ETH_RSS_xxx. > > 2. iavf_pattern_match_item->meta is the virtchnl_proto_hdrs template. > > 3. iavf_hash_parse_pattern will generate pattern hint. > > 4. iavf_hash_parse_action will refine the virtchnl_proto_hdrs base on > > pattern hint and ETH_RSS_xxx. > > 5. The refine process include > > 1) refine field selector of l2, l3, l4. > > 2) insert gtpu proto_hdr at the beginning base on pattern hint. > > 3) refine field selector for gtpu header. > > > > The patch reduce the code from 4000+ line to less than 1000. > > > > Note: > > The variable iavf_hash_pattern_list as the manifest of all supported > > pattern is intend to break the 80 char limitation for better review > > experience. > > > > Signed-off-by: Qi Zhang <qi.z.zh...@intel.com> Applied to dpdk-next-net-intel. Thanks Qi