Re: [dpdk-dev] [RFC] app/testpmd: distinguish ICMP identifier fields in packet

[Li Zhang]

Thanks! I update it now.

Regards,
Li Zhang

-----Original Message-----
From: Thomas Monjalon <tho...@monjalon.net> 
Sent: Tuesday, September 8, 2020 8:56 PM
To: Li Zhang <l...@nvidia.com>
Cc: Dekel Peled <dek...@nvidia.com>; Ori Kam <or...@nvidia.com>; Slava 
Ovsiienko <viachesl...@nvidia.com>; Matan Azrad <ma...@nvidia.com>; 
dev@dpdk.org; Raslan Darawsheh <rasl...@nvidia.com>
Subject: Re: [RFC] app/testpmd: distinguish ICMP identifier fields in packet

External email: Use caution opening links or attachments


Hi,

lizh <l...@nvidia.com> wrote:
> Ability to distinguish ICMP identifier fields in packets.
> Dstinguish ICMP sequence number field too.
> Already supports ICMP code and type fields in current version.
> Existing fields in ICMP header contain the required information.
> ICMP header already is supported and no code change in RTE FLOW.
> Extend testpmd CLI to include the fields of ident and sequence number.
> One example:
> flow create 0 ingress pattern eth / ipv4 /
>
>  icmp code is 1 ident is 5 seq is 6 /
>  end actions count / queue index 0 / end
>
> The ICMP packet with code 1, identifier 5 and sequence number 6 will 
> be matched.
> It will implement action counter and forward to queue 0.
>
> Signed-off-by: lizh <l...@nvidia.com>

Please configure your git environment so that your full name is filled. Then 
redo the Signed-off so that it appears as:
        Li Zhang <l...@nvidia.com>

As you are new to DPDK, I suggest reading the guidelines for contributing:
        
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcore.dpdk.org%2Fcontribute%2F%23send&amp;data=02%7C01%7Clizh%40nvidia.com%7C4d1f647de21844be83a408d853f69ab5%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637351665917806609&amp;sdata=dPG6VLa5HejKvwcGlqGKtfLwl%2BNEiybFSc5RUmmJDps%3D&amp;reserved=0