On Tue, 8 Sep 2020 09:18:08 +0100 Bruce Richardson <bruce.richard...@intel.com> wrote:
> On Mon, Sep 07, 2020 at 10:20:13AM -0700, Stephen Hemminger wrote: > > On Mon, 7 Sep 2020 09:58:27 +0100 > > Bruce Richardson <bruce.richard...@intel.com> wrote: > > > > > On Mon, Sep 07, 2020 at 09:54:29AM +0100, Ferruh Yigit wrote: > > > > On 9/6/2020 4:42 AM, Stephen Hemminger wrote: > > > > > This is an improved version of the setup of huge pages > > > > > bases on earlier DPDK setup. Differences are: > > > > > * it autodetects NUMA vs non NUMA > > > > > * it allows setting different page sizes > > > > > recent kernels support multiple sizes. > > > > > * it accepts a parameter in bytes (not pages). > > > > > > > > > > If necessary the steps of clearing old settings and mounting/umounting > > > > > can be done individually. > > > > > > > > > > Signed-off-by: Stephen Hemminger <step...@networkplumber.org> > > > > > > > > <...> > > > > > > > > > @@ -1,4 +1,9 @@ > > > > > # SPDX-License-Identifier: BSD-3-Clause > > > > > # Copyright(c) 2017 Intel Corporation > > > > > > > > > > -install_data(['dpdk-devbind.py', 'dpdk-pmdinfo.py', > > > > > 'dpdk-telemetry.py'], install_dir: 'bin') > > > > > +install_data([ > > > > > + 'dpdk-devbind.py', > > > > > + 'dpdk-pmdinfo.py', > > > > > + 'dpdk-telemetry.py', > > > > > + 'hugepage_setup.py' > > > > > +],install_dir: 'bin') > > > > > > > > > > > > > Should script name has 'dpdk-' prefix as others do? > > > > > > +1 to that. > > > > Ok but - in the name violates Python lint naming for modules. > > The standard is underscore. > > We don't really need 100% lint cleanliness for all our scripts, 95% is > surely enough. However, if you feel strongly, then I suggest we prefix all > our python scripts with "dpdk_", rather than "dpdk-" Agree. Just wanted to raise the observation. Maybe add a .pylintrc to usertools to suppress this warning.
