Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, January 27, 2015 8:13 PM > To: Ouyang, Changchun > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix an unnecessary check in vf rss > > > To follow up the comments from Wodkowski, PawelX, remove this > > unnecessary check, as check_mq_mode has already check the queue > number > > in device configure stage, if the queue number of vf is not correct, > > it will return error code and exit, so it doesn't need check again > > here in device start stage(note: pf_host_configure is called in device start > stage). > > > > This fixes commit 42d2f78abcb77ecb769be4149df550308169ef0f > > > > Signed-off-by: Changchun Ouyang <changchun.ouyang at intel.com> > > Suggested-by: Pawel Wodkowski <pawelx.wodkowski at intel.com> > Fixes: 42d2f78abcb77 ("configure VF RSS") > > Applied >
Thanks very much for the applying! > Changchun, as you are working on ixgbe, maybe you would like to review > some ixgbe patches from others? > No problem, I will try to do it when my bandwidth allows me to do it, :-) Thanks Changchun