On 9/1/2020 12:52 PM, Min Hu (Connor) wrote: > This series are minor change the queue ID type from > uint8_t to uint16_t. > > Huisong Li (2): > ethdev: change data type in TC rxq and TC txq > ethdev: fix compiling errors for per-queue statistics > > Min Hu (Connor) (2): > doc: announce modified field in DCB TC queue mapping > doc: announce modified field in ethdev API
Hi Min, Huisong, deprecation notices are part of the process and it should be prepared one release before current release, it is good for two things: - requiring three ack ensures ABI/API breakage is really necessary and approved by multiple parties - it notifies the breakage to the users at least one release in advance to give them time to prepare for it. It doesn't really have a benefit to add and remove the deprecation notice in the same release. For the patches above both are ABI breakages and normally requires deprecation notice to be announced from previous release to be able to change them in this release. BUT, both are fixes and and I guess there is nothing controversial to update them, also if they are not fixed in this release they will need to wait for at least a year, so I am for getting them without deprecation notice in place. Unless there is a strong objection to it, lets continue without deprecation notices, and you can drop those patches from the set. > > app/test-pmd/cmdline.c | 2 +- > app/test-pmd/config.c | 4 ++-- > app/test-pmd/testpmd.c | 2 +- > app/test-pmd/testpmd.h | 5 +++-- > doc/guides/rel_notes/release_20_11.rst | 7 +++++++ > drivers/net/igc/igc_ethdev.c | 4 ++-- > drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++-- > drivers/net/memif/rte_eth_memif.c | 2 +- > drivers/net/octeontx2/otx2_ethdev.h | 2 +- > drivers/net/octeontx2/otx2_stats.c | 2 +- > drivers/net/virtio/virtio_ethdev.c | 4 ++-- > lib/librte_ethdev/rte_ethdev.c | 6 +++--- > lib/librte_ethdev/rte_ethdev.h | 12 ++++++------ > lib/librte_ethdev/rte_ethdev_core.h | 2 +- > 14 files changed, 33 insertions(+), 25 deletions(-) >
