> -----Original Message-----
> From: Thomas Monjalon <tho...@monjalon.net>
> Sent: Tuesday, September 1, 2020 1:39 PM
> To: Nipun Gupta <nipun.gu...@nxp.com>; Stephen Hemminger
> <step...@networkplumber.org>; or...@mellanox.com
> Cc: dev@dpdk.org; ferruh.yi...@intel.com; arybche...@solarflare.com;
> Hemant Agrawal <hemant.agra...@nxp.com>; Rohit Raj <rohit....@nxp.com>;
> olivier.m...@6wind.com
> Subject: Re: [dpdk-dev] [PATCH] ethdev: add rx offload to drop error packets
>
> 31/08/2020 19:00, Stephen Hemminger:
> > On Mon, 31 Aug 2020 13:23:33 +0530
> > Nipun Gupta <nipun.gu...@nxp.com> wrote:
> >
> > > This change adds a RX offload capability where hardware can drop the
> > > packets in case there is an error in the packet such as L3 checksum
> > > error or L4 checksum.
> > >
> > > Signed-off-by: Nipun Gupta <nipun.gu...@nxp.com>
> > > Signed-off-by: Rohit Raj <rohit....@nxp.com>
> > > ---
> > > +#define DEV_RX_OFFLOAD_ERR_PKT_DROP 0x00100000
>
> Please add RTE_ prefix, even if older macros don't have it.
> We could (in a separate effort) alias old ones with RTE_ prefixed names.
Agree, will update and send the change along with testpmd and dpaa2 driver
change.
>
> > Could/should this be an rte_flow action as well?
>
> I feel rte_flow API is not appropriate here.
> Ori, any opinion?
>
