Hi qi
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Monday, August 31, 2020 12:23 PM
> To: Sun, GuinanX <guinanx....@intel.com>; dev@dpdk.org
> Cc: Yang, Qiming <qiming.y...@intel.com>; sta...@dpdk.org
> Subject: RE: [PATCH] net/ice: fix flow validation for unsupported patterns
>
>
>
> > -----Original Message-----
> > From: Sun, GuinanX <guinanx....@intel.com>
> > Sent: Friday, August 28, 2020 10:33 AM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zh...@intel.com>; Yang, Qiming
> > <qiming.y...@intel.com>; Sun, GuinanX <guinanx....@intel.com>;
> > sta...@dpdk.org
> > Subject: [PATCH] net/ice: fix flow validation for unsupported patterns
> >
> > When loading the OS default package and the pipeline mode is enabled
> > by the "pipeline-mode-support=1" operation. In this case, the wrong
> > parser is selected for processing and it will cause the unsupported
> > patterns(pppoes/pfcp/l2tpv3/esp/ah) to be validated successfully.
> > This patch corrects the parser selection issue.
> >
> > Fixes: 47d460d63233 ("net/ice: rework switch filter")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Guinan Sun <guinanx....@intel.com>
> > ---
> > drivers/net/ice/ice_switch_filter.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ice/ice_switch_filter.c
> > b/drivers/net/ice/ice_switch_filter.c
> > index c4b00b6a2..884fbaae2 100644
> > --- a/drivers/net/ice/ice_switch_filter.c
> > +++ b/drivers/net/ice/ice_switch_filter.c
> > @@ -1806,7 +1806,8 @@ ice_switch_init(struct ice_adapter *ad)
> > else
> > return -EINVAL;
> >
> > - if (ad->devargs.pipe_mode_support)
> > + if (ad->devargs.pipe_mode_support &&
> > + ad->active_pkg_type != ICE_PKG_TYPE_OS_DEFAULT)
> > ret = ice_register_parser(perm_parser, ad);
>
> This is not correct, package type should not related with pipe line mode.
Under the premise of pipe-mode support, the choice of parser for different
package types will be added.
Patch v2 will fix it.
>
>
> > else
> > ret = ice_register_parser(dist_parser, ad); @@ -1824,7
> +1825,8 @@
> > ice_switch_uninit(struct ice_adapter *ad)
> > else
> > dist_parser = &ice_switch_dist_parser_os;
> >
> > - if (ad->devargs.pipe_mode_support)
> > + if (ad->devargs.pipe_mode_support &&
> > + ad->active_pkg_type != ICE_PKG_TYPE_OS_DEFAULT)
> > ice_unregister_parser(perm_parser, ad);
> > else
> > ice_unregister_parser(dist_parser, ad);
> > --
> > 2.17.1
