On Wed, Jul 22, 2020 at 01:59:49PM +0100, Bruce Richardson wrote: > On Wed, Jul 22, 2020 at 02:45:54PM +0200, Thomas Monjalon wrote: > > 21/07/2020 17:39, Bruce Richardson: > > > When building the DPDK guide documents, the DPDK version information was > > > pulled using "make showversion", which meant there was a dependency on > > > the DPDK make-based build system. Change this to just read the data from > > > the VERSION file in the root directory. > > > > > > Signed-off-by: Bruce Richardson <bruce.richard...@intel.com> > > > --- > > > NOTE: When make build system is completed removed, we can change the > > > relative path to the VERSION file i.e. "../../", to instead pull the > > > path from "MESON_SOURCE_ROOT" in the environment, which should be more > > > robust. > > > > Yes it would be a bit better. > > If we merge this patch in 20.08, we'll forget about this improvement :) > > I suggest waiting 20.11 to merge the definitive improvement. > > > I'd prefer now, but I can be patient, I suppose. :-)
Updated and improved version of this patch is now part of the "make removal" patch series. Marking this standalone patch as superceded. /Bruce
