On Tue, Aug 18, 2020 at 12:40:53PM +0100, Bruce Richardson wrote: > On Fri, Aug 07, 2020 at 01:30:02PM +0100, Ciara Power wrote: > > Make is no longer supported for compiling DPDK, references are now > > removed in the documentation. > > > > Signed-off-by: Ciara Power <ciara.po...@intel.com> > > --- > > doc/guides/linux_gsg/build_dpdk.rst | 58 ------------------- > > doc/guides/linux_gsg/build_sample_apps.rst | 16 +---- > > .../linux_gsg/cross_build_dpdk_for_arm64.rst | 42 -------------- > > doc/guides/linux_gsg/enable_func.rst | 3 - > > doc/guides/linux_gsg/intro.rst | 2 +- > > doc/guides/linux_gsg/linux_drivers.rst | 2 - > > doc/guides/linux_gsg/sys_reqs.rst | 4 -- > > 7 files changed, 4 insertions(+), 123 deletions(-) > > > <snip> > > diff --git a/doc/guides/linux_gsg/sys_reqs.rst > > b/doc/guides/linux_gsg/sys_reqs.rst > > index a124656bcb..a009f3146b 100644 > > --- a/doc/guides/linux_gsg/sys_reqs.rst > > +++ b/doc/guides/linux_gsg/sys_reqs.rst > > @@ -85,10 +85,6 @@ A number of DPDK components, such as libraries and > > poll-mode drivers (PMDs) have > > For DPDK builds using meson, the presence or absence of these dependencies > > will be > > automatically detected enabling or disabling the relevant components > > appropriately. > > > > I think you can drop the words "using meson" here as there is no > alternative any more. > > > -For builds using make, these components are disabled in the default > > configuration and > > -need to be enabled manually by changing the relevant setting to "y" in the > > build configuration file > > -i.e. the ``.config`` file in the build folder. > > - > > In each case, the relevant library development package (``-devel`` or > > ``-dev``) is needed to build the DPDK components. > > > > For libraries the additional dependencies include: > > In sys_reqs.rst there is also a reference to make in the "Required Tools > and Libraries". Change: > > "General development tools including make, and a supported C compiler such > as gcc (version 4.9+) or clang (version 3.4+)." > > To something like: > > "General development tools including a supported C compiler such > as gcc (version 4.9+) or clang (version 3.4+)."
Also, one more thing I spot in that section is that we need to update our python minimum version to 3.5+ and drop references to 2.7. Therefore, I'd suggest just removing the whole sub-bullets and put a single bullet saying "Python, v3.5 or later"
