Hi All This patch needs to get reviewed by all available reviewers as link came visible now.
@Xia Chenbo, As you have already reviewed so here I request you to share your review vote again and Ack if possible. @Ferruh, Below link is correct patch, I appreciate and thank you very much for your help. Patch Link: https://urldefense.com/v3/__https://patches.dpdk.org/project/dpdk/list/?submitter=1867__;!!GqivPVa7Brio!JuQy9aSMyTDxpgEERG6JThvjCeZ0vbjYktEIDtU-JSHQalUpEoAp3u4diGxyy98kmw$ Regards Vipul -----Original Message----- From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] Sent: Wednesday, 19 August, 2020 0:15 To: Vipul Ashri <vipul.as...@oracle.com>; Xia, Chenbo <chenbo....@intel.com>; dev@dpdk.org; sta...@dpdk.org; Wang, Zhihong <zhihong.w...@intel.com>; maxime.coque...@redhat.com Cc: Edwin Leung <edwin.le...@oracle.com> Subject: Re: [dpdk-dev] [PATCH v3] net/virtio: fix wrong variable assignment in helper macro On 8/14/2020 6:23 AM, Vipul Ashri wrote: > Hi All > > I tried twice uploading this same patch but it is still not listed under > https://urldefense.com/v3/__http://patches.dpdk.org/project/dpdk/list/__;!!GqivPVa7Brio!JuQy9aSMyTDxpgEERG6JThvjCeZ0vbjYktEIDtU-JSHQalUpEoAp3u4diGy8g7AhJA$ > . > Please let me know if I am missing something and required to do some > additional steps to submit my patch. Mail list is moderated, only subscribed members can post. Your patches were hold in the administration queue because of that, I have released them and cleaned up the patchwork (since there were double of some versions) and only left one copy of v3, please check if that is the correct one: https://urldefense.com/v3/__https://patches.dpdk.org/project/dpdk/list/?submitter=1867__;!!GqivPVa7Brio!JuQy9aSMyTDxpgEERG6JThvjCeZ0vbjYktEIDtU-JSHQalUpEoAp3u4diGxyy98kmw$ > > Thanks to Xia for reviewing this code! > > Regards > Vipul > > -----Original Message----- > From: Xia, Chenbo [mailto:chenbo....@intel.com] > Sent: Friday, 14 August, 2020 6:56 > To: Vipul Ashri <vipul.as...@oracle.com>; dev@dpdk.org > Cc: Edwin Leung <edwin.le...@oracle.com>; sta...@dpdk.org; Wang, > Zhihong <zhihong.w...@intel.com>; maxime.coque...@redhat.com > Subject: RE: [PATCH v3] net/virtio: fix wrong variable assignment in > helper macro > > >> -----Original Message----- >> From: Vipul Ashri <vipul.as...@oracle.com> >> Sent: Friday, August 14, 2020 12:22 AM >> To: dev@dpdk.org >> Cc: Xia, Chenbo <chenbo....@intel.com>; vipul.as...@oracle.com; >> edwin.le...@oracle.com; sta...@dpdk.org; Wang, Zhihong >> <zhihong.w...@intel.com>; maxime.coque...@redhat.com >> Subject: [PATCH v3] net/virtio: fix wrong variable assignment in >> helper macro >> >> Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is >> always failing as assignment done using var_ having local scope only. >> This leads to TX packets not going out and found broken due to >> cleanup malfunctioning. This patch fixes the wrong variable assignment. >> >> Fixes: 57f90f894588 ("net/virtio: reuse packed ring functions") >> Cc: sta...@dpdk.org >> >> Signed-off-by: Vipul Ashri <vipul.as...@oracle.com> >> --- >> drivers/net/virtio/virtqueue.h | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/net/virtio/virtqueue.h >> b/drivers/net/virtio/virtqueue.h index 105a9c00c..20c95471e 100644 >> --- a/drivers/net/virtio/virtqueue.h >> +++ b/drivers/net/virtio/virtqueue.h >> @@ -607,10 +607,8 @@ virtqueue_notify(struct virtqueue *vq) >> >> /* avoid write operation when necessary, to lessen cache issues */ >> #define ASSIGN_UNLESS_EQUAL(var, val) do { \ >> - typeof(var) var_ = (var); \ >> - typeof(val) val_ = (val); \ >> - if ((var_) != (val_)) \ >> - (var_) = (val_); \ >> + if ((var) != (val)) \ >> + (var) = (val); \ >> } while (0) >> >> #define virtqueue_clear_net_hdr(hdr) do { \ >> -- >> 2.28.0.windows.1 > > Reviewed-by: Chenbo Xia <chenbo....@intel.com> >
