> -----Original Message----- > From: Wang, ShougangX <[email protected]> > Sent: Thursday, August 6, 2020 18:28 > To: [email protected] > Cc: Yang, Qiming <[email protected]>; Zhang, Qi Z > <[email protected]>; Wang, ShougangX <[email protected]>; > [email protected] > Subject: [PATCH v2] net/ice: fix incorrect firmware version > > Kernel driver shows firmware version as hex but ice PMD shows as decimal. > This patch fixes the issue to make consistent with kernel driver. > > Fixes: f9204d8a23c3 ("net/ice: fix firmware version result of ethtool") > Cc: [email protected] > > Signed-off-by: Shougang Wang <[email protected]> > --- > v2: > corrected fixes version > --- > drivers/net/ice/ice_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c > index 8d435e889..88b8428b9 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -4388,7 +4388,7 @@ ice_fw_version_get(struct rte_eth_dev *dev, char > *fw_version, size_t fw_size) > build = hw->nvm.orom.build; > > ret = snprintf(fw_version, fw_size, > - "%d.%d 0x%08x %d.%d.%d", > + "%x.%02x 0x%08x %d.%d.%d", > hw->nvm.major_ver, > hw->nvm.minor_ver, > hw->nvm.eetrack, > -- > 2.17.1
Acked-by: Qiming Yang <[email protected]>
