> -----Original Message-----
> From: Thomas Monjalon <tho...@monjalon.net>
> Sent: Wednesday, August 5, 2020 11:31 PM
> To: Suanming Mou <suanmi...@mellanox.com>
> Cc: John McNamara <john.mcnam...@intel.com>; Marko Kovacevic
> <marko.kovace...@intel.com>; dev@dpdk.org; Raslan Darawsheh
> <rasl...@mellanox.com>; Asaf Penso <as...@mellanox.com>; Gal Cohen
> (Product) <ga...@mellanox.com>
> Subject: Re: [dpdk-dev] [PATCH] doc: update release notes for mlx5 PMD
>
> 19/07/2020 13:59, Suanming Mou:
> > Update the release notes of mlx5 PMD for two new added devargs:
> > 1. sys_mem_en
> > 2. decap_en
>
> That's a pity it was not sent as part of code implementation.
>
> Please, at least, add the Fixes lines.
OK, will add the Fixes lines.
>
> > Signed-off-by: Suanming Mou <suanmi...@mellanox.com>
> > ---
> > --- a/doc/guides/rel_notes/release_20_08.rst
> > +++ b/doc/guides/rel_notes/release_20_08.rst
> > @@ -123,6 +123,8 @@ New Features
> > * Added new PMD devarg ``reclaim_mem_mode``.
> > * Added new devarg ``lacp_by_user``.
> > * Added support for eCPRI protocol offloading.
> > + * Added new devarg ``decap_en``.
> > + * Added new devarg ``sys_mem_en``.
>
> You could group by moving up with other devargs in a logical order.
> I think we could even group all devargs in a single list item.
Good idea. Thanks.
>
>
