31/07/2020 07:03, Ajit Khaparde: > On Thu, Jul 30, 2020 at 7:35 PM Gaurav Singh <gaurav1...@gmail.com> wrote: > > > vxlan_mask cannot be NULL since its already being accessed > > before. Remove the redundant NULL check.
Do you mean vxlan_spec? > > Signed-off-by: Gaurav Singh <gaurav1...@gmail.com> > > > Acked-by: Ajit Khaparde <ajit.khapa...@broadcom.com> The title has a typo: bxnt > > /* Check if VNI is masked. */ > > - if (vxlan_spec && vxlan_mask) { > > + if (vxlan_mask) { This kind of implicit check is against the coding style. Except for boolean variables, we should use == or != Ajit, please check details when reviewing, thanks.